Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

[Documentation] Should README setup example use http_archive rather than git_repository? #126

Open
wadejensen opened this issue Aug 2, 2020 · 1 comment

Comments

@wadejensen
Copy link

wadejensen commented Aug 2, 2020

http_archive seems to be the standard method for pulling rules into a WORKSPACE in the bazel ecosystem. Should the README example for this repo

https://github.com/google/subpar/blame/9fae6b63cfeace2e0fb93c9c1ebdc28d3991b16f/README.md#L14-L24

be changed to something like the following?

# Subpar
subpar_version = "35bb9f0092f71ea56b742a520602da9b3638a24f"  # 2.0.0

http_archive(
    name = "subpar",
    sha256 = "34bb4dadd86bbdd3b5736952167e20a1a4c27ff739de11532c4ef77c7c6a68d9",
    strip_prefix = "subpar-{version}".format(version = subpar_version),
    url = "https://github.com/google/subpar/archive/{version}.tar.gz".format(version = subpar_version),
)
@samtstern
Copy link

This saved me, you should send a PR to the README!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants