Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid verilog syntax at sky130_fd_sc_hd__lpflow_bleeder.functional.v #298

Open
Manarabdelaty opened this issue Jan 26, 2021 · 1 comment

Comments

@Manarabdelaty
Copy link

Expected Behavior

The endif directive should be followed by the macro name commented out. Correct behavior is like

endif // SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_PP_V

where the macro the name is commented out

https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.pp.v;l=44

Actual Behavior

The functional model of the sky130_fd_sc_hd__lpflow_bleeder cell has invalid verilog syntax at

endif SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_V

because the macro name isn't commented out.

https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.v

Steps to Reproduce the Problem

Compiling the verilog file using iverilog will flag a syntax error.

1. iverilog sky130_fd_sc_hd__lpflow_bleeder.functional.v

Specifications

  • Version:
  • Platform:
@RTimothyEdwards
Copy link
Collaborator

Corrected in pull request #4 to https://github.com/efabless/skywater-pdk-libs-sky130_fd_sc_hd fork, which automatically updates the upstream repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants