Update periodic connection check for accuracy

[aaemnnosttv]

Feature Description

In #9083 we updated the periodic connection check Site Kit performs which tests for internet connectivity by pinging our REST index endpoint. There is still the potential for inaccurate behavior in the event that the request fails – this happened for me recently when my session timed out and the request failed due to a bad REST nonce. Such a failure is irrelevant to this check though which is only concerned with the request connecting to the backend successfully, rather than authenticating, etc.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The internet connectivity check should only trigger the offline notification if the backend is unreachable

Implementation Brief

• Update the fetch made to use fetch rather than apiFetch (adapting as necessary) and remove checks on its response (if the call does not throw, consider online=true, otherwise catch and set false
  

  site-kit-wp/assets/js/hooks/useMonitorInternetConnection.js

  Lines 55 to 67 in 3a6fd17

  	try {
  	const connectionCheckResponse = await apiFetch( {
  	path: '/google-site-kit/v1/',
  	} );
  	// We are only interested if the request was successful, to
  	// confirm online status.
  	const canReachConnectionCheck = !! connectionCheckResponse;
  	setIsOnline( canReachConnectionCheck );
  	} catch ( err ) {
  	setIsOnline( false );
  	}

• api-fetch cannot be used because it will throw for any non 200-300 response

Test Coverage

• Update existing coverage as needed

QA Brief

1. Install tweak extension and add following rule.

• URL: https://domain.com/google-site-kit/v1/
• HTTP Method: GET
• Status code: 400
• Delay: 1000
• Response payload:

   {
    "code": "test_error",
    "message": "Error message.",
    "data": { "reason": "" }
  }

2. Go to Site Kit dashboard. Disconnect from the internet connection on your system.

3. Notice that the offline notice should appear.

4. Re-connect to internet and warning should go away. Make sure that request was intercepted by tweak.

Changelog entry

• Improve accuracy of periodic network connection check.

[eugene-manuilov]

IB ✔

[wpdarren]

QA Update: ✅

Verified:

• Following QAB instructions.
• Noticed that the offline notice should appear.
• Re-connect to internet and warning goes away. The request was intercepted by tweak.