Update invariant use within datastore generator functions

[aaemnnosttv]

Bug Description

In #1801 we updated the way createFetchStore works internally so that invalid use raises errors as expected.

As discovered in that issue, the main problem is that errors raised in a generator function do not throw but instead result in a rejected promise which is not handled well.

We still have many instances of invariant used within generators in the datastore outside of the createFetchStore use.

E.g.

site-kit-wp/assets/js/googlesitekit/modules/datastore/modules.js

Lines 181 to 183 in 62c8243

	*setModuleActivation( slug, active ) {
	invariant( slug, 'slug is required.' );
	invariant( active !== undefined, 'active is required.' );

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• A new createValidatedAction utility should be created for simplifying the definition of an async action that has validation
  • It should take two arguments: validate (a non-generator function), actionCreator (a function which may or may not be a generator that returns and/or yields actions)
• All instances of action creators in the data store which are generators that perform validation on parameters (i.e. invariant) should be updated to use the new utility

Implementation Brief

• Finish and merge Fix/1941 validated actions #3158
  • Add tests for createValidatedAction
  • Update remaining actions

QA Brief

• Review the codebase to make sure there are no longer any actions defined as generator functions which call invariant internally

Changelog entry

• N/A

[aaemnnosttv]

@felixarntz moving this forward to AC as there are still quite a few of these in the codebase.

[aaemnnosttv]

@felixarntz please review the ACs here as well. You can see what the proposed changes look like with one action here:
https://github.com/google/site-kit-wp/pull/3158/files?diff=split&w=1

[felixarntz]

@aaemnnosttv I like the approach you're suggesting, great! IB ✅

[wpdarren]

@aaemnnosttv just checking this should be a QA:Eng ticket since it mentions looking at the codebase?

[aaemnnosttv]

Yep, thanks @wpdarren – I've added it now 👍

[tofumatt]

QA ✅