Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @wordpress/scripts to its latest version #1770

Closed
felixarntz opened this issue Jul 13, 2020 · 3 comments
Closed

Update @wordpress/scripts to its latest version #1770

felixarntz opened this issue Jul 13, 2020 · 3 comments
Labels
Good First Issue Good first issue for new engineers P2 Low priority QA: Eng Requires specialized QA by an engineer Type: Enhancement Improvement of an existing feature
Milestone

Comments

@felixarntz
Copy link
Member

felixarntz commented Jul 13, 2020

Feature Description

The @wordpress/scripts dependency (currently used on 3.4.0) should be updated to its latest version. The newer versions include / depend on a new @wordpress/jest-console package though, which requires us to change many of our Jest tests to account for this change. See #1763 (comment) for more information.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • @wordpress/scripts should be updated to its latest version (newer than 3.4.0).
  • Fix all unexpected console logging in Jest tests. Console logging in any test which is not expected should cause the test to fail.
  • There should be no errors on Site Kit screens, and tests should pass (obviously).

Implementation Brief

  • Upgrade @wordpress/scripts to the latest version.
  • Update javascript tests to explicitly call expect( console ).toHaveErrored(), expect( console ).toHaveWarned() or expect( console ).toHaveLogged() when a console output is expected.
  • Remove muteConsole calls from all javascript tests.
  • Remove muteConsole function from tests/js/utils.js file.

QA Brief

  • Running npm run test:js does not result in any errors or display any unexpected console logging (all console logs should fail tests)
  • App functions normally without breakage

Changelog entry

  • N/A
@felixarntz felixarntz added P2 Low priority Type: Enhancement Improvement of an existing feature QA: Eng Requires specialized QA by an engineer labels Jul 13, 2020
@felixarntz felixarntz self-assigned this Jul 13, 2020
@felixarntz felixarntz added Next Up P1 Medium priority and removed P2 Low priority labels Jul 27, 2020
@felixarntz felixarntz removed their assignment Jul 27, 2020
@felixarntz
Copy link
Member Author

IB ✅ , however we should only add the console expect statements if they are actually expected. For cases where an error is logged because e.g. we forgot to intercept a request that we should have intercepted, that should be fixed by intercepting it.

@eclarke1 eclarke1 modified the milestone: Sprint 30 Aug 11, 2020
@eclarke1 eclarke1 added this to the Sprint 31 milestone Aug 25, 2020
@tofumatt tofumatt added the Good First Issue Good first issue for new engineers label Sep 3, 2020
@felixarntz felixarntz added P2 Low priority and removed P1 Medium priority labels Sep 4, 2020
@caseymorrisus caseymorrisus self-assigned this Sep 4, 2020
@caseymorrisus caseymorrisus removed their assignment Sep 14, 2020
@eclarke1 eclarke1 modified the milestones: Sprint 31, Sprint 32 Sep 15, 2020
@aaemnnosttv aaemnnosttv self-assigned this Sep 15, 2020
@aaemnnosttv
Copy link
Collaborator

@caseymorrisus would you please add a QA Brief here as well?

@aaemnnosttv aaemnnosttv removed their assignment Sep 15, 2020
@tofumatt
Copy link
Collaborator

QA ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers P2 Low priority QA: Eng Requires specialized QA by an engineer Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants