-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @wordpress/scripts to its latest version #1770
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
QA: Eng
Requires specialized QA by an engineer
Type: Enhancement
Improvement of an existing feature
Milestone
Comments
This was referenced Jul 13, 2020
IB ✅ , however we should only add the console expect statements if they are actually expected. For cases where an error is logged because e.g. we forgot to intercept a request that we should have intercepted, that should be fixed by intercepting it. |
6 tasks
@caseymorrisus would you please add a QA Brief here as well? |
QA ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
QA: Eng
Requires specialized QA by an engineer
Type: Enhancement
Improvement of an existing feature
Feature Description
The
@wordpress/scripts
dependency (currently used on 3.4.0) should be updated to its latest version. The newer versions include / depend on a new@wordpress/jest-console
package though, which requires us to change many of our Jest tests to account for this change. See #1763 (comment) for more information.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
@wordpress/scripts
should be updated to its latest version (newer than 3.4.0).Implementation Brief
@wordpress/scripts
to the latest version.expect( console ).toHaveErrored()
,expect( console ).toHaveWarned()
orexpect( console ).toHaveLogged()
when a console output is expected.muteConsole
calls from all javascript tests.muteConsole
function fromtests/js/utils.js
file.QA Brief
npm run test:js
does not result in any errors or display any unexpected console logging (all console logs should fail tests)Changelog entry
The text was updated successfully, but these errors were encountered: