Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky E2E test in specs/modules/analytics/setup-gcp-no-account-no-tag.test.js. #10108

Open
1 task
techanvil opened this issue Jan 23, 2025 · 0 comments
Open
1 task
Labels
P0 High priority Type: Infrastructure Engineering infrastructure & tooling

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jan 23, 2025

Feature Description

We still have a number of E2E tests failing with some regularity in our CI test runs. The task of fixing them has been split into four issues in order to make it easier to investigate and fix. See #10109, #10110, #10111.

setting up the Analytics module using GCP auth with no existing account and no existing tag › displays account creation form when user has no Analytics account

Example: https://github.com/google/site-kit-wp/actions/runs/12874436085/job/35893852219#step:11:249

Details
FAIL specs/modules/analytics/setup-gcp-no-account-no-tag.test.js (11.522 s)
  ● setting up the Analytics module using GCP auth with no existing account and no existing tag › displays account creation form when user has no Analytics account

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Google Site Kit API Error method:POST datapoint:settings type:modules identifier:analytics-4 error:\"The response is not a valid JSON response.\""],["Google Site Kit API Error method:GET datapoint:account-summaries type:modules identifier:analytics-4 error:\"The response is not a valid JSON response.\""]

      at Object.assertExpectedCalls (../../node_modules/@wordpress/jest-console/build/@wordpress/jest-console/src/index.js:36:4)
          at runMicrotasks (<anonymous>)

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The test listed in the Feature Description should pass every time in CI.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

1 participant