Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing new badge when setting KMW in full screen for the first time #10083

Open
2 tasks
zutigrm opened this issue Jan 20, 2025 · 1 comment
Open
2 tasks

Showing new badge when setting KMW in full screen for the first time #10083

zutigrm opened this issue Jan 20, 2025 · 1 comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Jan 20, 2025

Feature Description

Currently when property with pre-existing conversion events is connected, and KMW is being set up for the first time in full screen, do we want to show new badges for conversion events and groups? Or perhaps omit it in this specific scenario

Image

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When KMW setup is done initially with an analytics property that already have conversion events, new badges and group dots should not show

Implementation Brief

  • In includes/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_Sync.php
    • Add new constant for, say googlesitekit_conversion_reporting_skip_new_badge_events
    • Update sync_new_badge_events method
      • At the beginning of the method, check if the transient googlesitekit_conversion_reporting_skip_new_badge_events is present, and if it is, delete it and return early
  • In includes/Modules/Analytics_4.php
    • Before CRON callback is called
      do_action( Conversion_Reporting_Cron::CRON_ACTION );
      set the googlesitekit_conversion_reporting_skip_new_badge_events transient. You can use 1 for the value for example

Test Coverage

  • Update tests/phpunit/integration/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_SyncTest.php tests, to verify that when transient is present and sync_new_badge_events is invoked NEW_EVENTS_BADGE_TRANSIENT is not set and googlesitekit_conversion_reporting_skip_new_badge_events is deleted

QA Brief

Changelog entry

@zutigrm zutigrm added P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Jan 20, 2025
@zutigrm zutigrm self-assigned this Jan 20, 2025
@zutigrm zutigrm added Type: Bug Something isn't working and removed Type: Enhancement Improvement of an existing feature labels Jan 20, 2025
@zutigrm zutigrm removed their assignment Jan 21, 2025
@10upsimon 10upsimon self-assigned this Jan 22, 2025
@10upsimon
Copy link
Collaborator

@zutigrm IB LGTM, ✅

@10upsimon 10upsimon removed their assignment Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants