You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when property with pre-existing conversion events is connected, and KMW is being set up for the first time in full screen, do we want to show new badges for conversion events and groups? Or perhaps omit it in this specific scenario
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
When KMW setup is done initially with an analytics property that already have conversion events, new badges and group dots should not show
Implementation Brief
In includes/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_Sync.php
Add new constant for, say googlesitekit_conversion_reporting_skip_new_badge_events
Update sync_new_badge_events method
At the beginning of the method, check if the transient googlesitekit_conversion_reporting_skip_new_badge_events is present, and if it is, delete it and return early
set the googlesitekit_conversion_reporting_skip_new_badge_events transient. You can use 1 for the value for example
Test Coverage
Update tests/phpunit/integration/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_SyncTest.php tests, to verify that when transient is present and sync_new_badge_events is invoked NEW_EVENTS_BADGE_TRANSIENT is not set and googlesitekit_conversion_reporting_skip_new_badge_events is deleted
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered:
Feature Description
Currently when property with pre-existing conversion events is connected, and KMW is being set up for the first time in full screen, do we want to show new badges for conversion events and groups? Or perhaps omit it in this specific scenario
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
includes/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_Sync.php
googlesitekit_conversion_reporting_skip_new_badge_events
sync_new_badge_events
methodgooglesitekit_conversion_reporting_skip_new_badge_events
is present, and if it is, delete it and return earlyincludes/Modules/Analytics_4.php
site-kit-wp/includes/Modules/Analytics_4.php
Line 313 in 1d98c6f
googlesitekit_conversion_reporting_skip_new_badge_events
transient. You can use1
for the value for exampleTest Coverage
tests/phpunit/integration/Modules/Analytics_4/Conversion_Reporting/Conversion_Reporting_New_Badge_Events_SyncTest.php
tests, to verify that when transient is present andsync_new_badge_events
is invokedNEW_EVENTS_BADGE_TRANSIENT
is not set andgooglesitekit_conversion_reporting_skip_new_badge_events
is deletedQA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: