Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split_by_number only splits Western Arabic Numerals and Full-Width Digits #1077

Open
Numeri opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@Numeri
Copy link

Numeri commented Jan 15, 2025

split_by_number is really nice for ensuring models learn to treat each digit separately, but the current implementation only applies to Western Arabic and Full-Width digits:

0123456789
0123456789

It'd be nice to include anything in the Unicode General Category Nd (Numeric, decimal digits), so that it covers Eastern Arabic numerals, Chinese numerals, etc.:

۰۱۲۳۴۵۶۷۸۹
零一二三四五六七八九十百千萬億
〇一二三四五六七八九十百千万亿

We could also cover the whole category N, which would also included non-digit numeric characters, like the ¹ (SUPERSCRIPT ONE) or (ROMAN NUMERAL TEN, not the letter X), but I'm not sure how intuitive it is to include those, or how often it even matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant