Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings with GCC 5.4 #13

Closed
graetzer opened this issue Mar 25, 2018 · 3 comments
Closed

Warnings with GCC 5.4 #13

graetzer opened this issue Mar 25, 2018 · 3 comments
Assignees
@jmr

Comments

@graetzer
Copy link
Contributor

I noticed quite a lot of warnings in clang due to signed / unsigned integer comparison as well as structs that were forward declared as classes.

Would it be ok to submit a pull request which silences some of these ?
@jmr
Copy link
Member

jmr commented Mar 30, 2018

That's fine, but you'll have to sign a CLA. It's probably easier if I just fix them.

@jmr jmr self-assigned this Mar 30, 2018
@jmr
Copy link
Member

jmr commented Apr 3, 2018

It looks easier to sign the CLA than I thought.

Do you want to send me a PR with some example fixes, then do everything when those look ok?

@graetzer
Copy link
Contributor Author

graetzer commented Apr 3, 2018

Yes, my collegue @danielhlarkin already submitted some of our patches, I will send some more when I get the time

@graetzer graetzer mentioned this issue May 3, 2018
Closed
@smcallis smcallis mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmr jmr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graetzer @jmr