Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found 1 file excluded from sound null safety #672

Closed
Tracked by #49169
devoncarew opened this issue Jun 3, 2022 · 3 comments
Closed
Tracked by #49169

Found 1 file excluded from sound null safety #672

devoncarew opened this issue Jun 3, 2022 · 3 comments

Comments

@devoncarew
Copy link
Collaborator

Found 1 file excluded from sound null safety:

protoc_plugin/test/generated_message_test.dart:6:// @dart=2.11

See dart-lang/sdk#49169 for more context.

@devoncarew
Copy link
Collaborator Author

@osa1 - can you validate that this is correct (isn't a false positive from my script), and if so finish the conversion?

@osa1
Copy link
Member

osa1 commented Jun 7, 2022

@devoncarew we deliberately left that file when we made the rest of the code null safe: #642 (comment)

Copying my comment from the link:

The test file generated_message_test.dart is not made null-safe in this PR. We test some exception-throwing behavior in that file and making it null-safe makes some of those runtime errors type errors, so we lose some test coverage. I suggest we don't update that file.

@devoncarew
Copy link
Collaborator Author

Sounds good! Closing this issue then as that exclusion is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants