-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ':' as the option delimiter breaks Windows build for some plugins #210
Comments
@xfxyjwf we currently use |
":" is definitely not good. Maybe "|" and document that's a separator? |
I guess we can't change to use a different separator because it's not backwards compatible. I think you can probably make use of the "---xxx_opt" flag: $ protoc --myplugin_opt=C:/myproject/src/main/resources/mytemplate --myplugin_out=... ... That way the option containing ":" should be passed to the plugin as is. |
Thanks @xfxyjwf . At which protoc version was the |
It was added in this commit: Released in protobuf 3.2.0. |
I misunderstood the case. The offending |
This issue has impacted some users of a plugin I author. I submitted a PR that checks if the version of protoc plugin configured is compatible and uses the opt flag instead. This isn’t fool proof solution by any means since it only works if they configure the locator via artifact notation. I figured some support is better than none. |
We have relative problem in our project (I've described it here https://stackoverflow.com/q/69853032/2313177). Could you advice a workaround? |
If I understand this correctly, this really is something that happens in the @akryvtsun Does your |
For plugins that accept options for configuration of, say file location. One would sometimes set something like
myplugin {
option "${projectDir}"/src/main/resources/mytemplate"
}
And that breaks in Windows because the plugin is forming a command with stuff like
myplugin_out=C:/myproject/src/main/resources/mytemplate:...
and that breaks because the protobuf plugin now just pass myplugin_out=C to the plugin myplugin as it parses the options expecting ":" are delimiters.
Maybe it should use a different character for delimiter, something that does not cause platform directory parth issue.
The text was updated successfully, but these errors were encountered: