Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for ghc-8.6.1 #236

Closed
mpickering opened this issue Sep 17, 2018 · 6 comments
Closed

Release for ghc-8.6.1 #236

mpickering opened this issue Sep 17, 2018 · 6 comments

Comments

@mpickering
Copy link

This issue is to track progress towards releasing a version of proto-lens which is compatible with ghc-8.6.1 which will be released in the next few days.

@mpickering mpickering changed the title Relase for ghc-8.6.1 Release for ghc-8.6.1 Sep 17, 2018
@judah
Copy link
Collaborator

judah commented Sep 17, 2018

I just tried a quick hack to the repo's stack.yaml to see where the build currently fails:

https://gist.github.com/judah/02672a86ba65852e5a57fbefd65767bb

Some packages (both dependencies and proto-lens-*) need bounds to be bumped, which I assume will happen after the actual release of 8.6.1. Notably, polyparse which is used transitively by haskell-src-exts also needs an update due to how MonadFail works.

Log: https://gist.github.com/judah/02672a86ba65852e5a57fbefd65767bb

@mpickering
Copy link
Author

haskell-src-exts is my responsibility but like you say, I can't do a release until polyparse is updated.

@mpickering
Copy link
Author

I just released haskell-src-exts-1.20.3 which is compatible with ghc-8.6.1.

@judah
Copy link
Collaborator

judah commented Sep 28, 2018

Update: I've created a branch (ghc-8.6) for this task, which mostly works: https://github.com/google/proto-lens/compare/ghc-8.6?expand=1

However, this requires using some dependencies that aren't released yet (e.g. tagged, contravariant), and a couple local packages still aren't built (proto-lens-benchmarks and proto-lens-discrimination) due to dependencies that haven't been upgraded yet.

At this point I'm planning to wait another couple weeks for the dependencies to get updated and released.

@mpickering
Copy link
Author

Thanks Judah. That will be enough for me to get started.

@judah
Copy link
Collaborator

judah commented Oct 13, 2018

I've released proto-lens-0.4.0.1 (and related versions of the other packages) which are all compatible with ghc-8.6.1.

@judah judah closed this as completed Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants