Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Provide ability to configure google-services.json location via plugin DSL #275

Open
originx opened this issue Sep 12, 2023 · 2 comments

Comments

@originx
Copy link

originx commented Sep 12, 2023

It would be a nice feature from dev-user perspective to decide where to keep config files especially in more complex projects, would you consider providing a way to configure this part of the plugin via the DSL.

Actual:
Plugin search for locations of google-services.json file in various locations as best guess depending on project where plugin is applied on

Change:

  • Let plugin be configurable via DSL so location of the file can be configurable and users can better organize their projects
  • if file location is passed do not check fallback locations that are currently searched for

Kotlin DSL (KTS)

android {
    // ...
    productFlavors {
        create("myFlavor") {
            // Other flavor configurations
            googleServices {
                // Customize the google-services.json file location
                googleServicesFileLocation.set(file("$rootProject/config/google-services.json"))
            }
        }
    }
    // ...
}

Groovy DSL

android {
    // ...
    productFlavors {
        myFlavor {
            // Other flavor configurations
            googleServices {
                // Customize the google-services.json file location
                googleServicesFileLocation = file("$rootProject/config/google-services.json")
            }
        }
    }
    // ...
}
@originx
Copy link
Author

originx commented Jun 11, 2024

this seems like a reasonable request, it is possible to do a PR but I see no activity on this repo, is this project still being maintained?

@ivanorsolic
Copy link

+1 Would be nice to get a response?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants