From 65c56255b82a13cc2b521b12cedf165b696261b5 Mon Sep 17 00:00:00 2001
From: Ted Pudlik <tpudlik@google.com>
Date: Thu, 1 Aug 2024 19:03:13 +0000
Subject: [PATCH] pw_system: Don't use implementation_deps
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is just a temporary mitigation for a lack of support for
implementation_deps internally. I hope to revert this within weeks.

Bug: 304374970
Bug: 356667663
Change-Id: I16cc22c36960cb53676591709f5402f2a8032370
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/226977
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
---
 pw_system/BUILD.bazel | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/pw_system/BUILD.bazel b/pw_system/BUILD.bazel
index b97828d784..b1b6159765 100644
--- a/pw_system/BUILD.bazel
+++ b/pw_system/BUILD.bazel
@@ -556,7 +556,8 @@ cc_library(
         "threads.cc",
     ],
     hdrs = ["public/pw_system/system.h"],
-    implementation_deps = [
+    includes = ["public"],
+    deps = [
         ":async_packet_io",
         ":device_service",
         ":file_manager",
@@ -565,12 +566,16 @@ cc_library(
         ":thread_snapshot_service",
         ":transfer_service",
         ":work_queue",
+        "//pw_allocator:allocator",
         "//pw_allocator:best_fit_block_allocator",
         "//pw_allocator:synchronized_allocator",
         "//pw_async2:allocate_task",
+        "//pw_async2:dispatcher",
         "//pw_async2:pend_func_task",
+        "//pw_channel",
         "//pw_hdlc:router",
         "//pw_multibuf:simple_allocator",
+        "//pw_rpc",
         "//pw_rpc/pwpb:echo_service",
         "//pw_sync:interrupt_spin_lock",
         "//pw_thread:thread",
@@ -581,13 +586,6 @@ cc_library(
         ],
         "//conditions:default": [],
     }),
-    includes = ["public"],
-    deps = [
-        "//pw_allocator:allocator",
-        "//pw_async2:dispatcher",
-        "//pw_channel",
-        "//pw_rpc",
-    ],
 )
 
 cc_library(