From 49098a4445af1f8b8448affb3feeb24853285309 Mon Sep 17 00:00:00 2001
From: Wyatt Hepler <hepler@google.com>
Date: Thu, 28 Apr 2022 16:57:20 -0700
Subject: [PATCH] pw_rpc: Add more debug logs

Change-Id: I2bb2298c70c3544e6fdb16d8680afcc4954b6eba
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/92717
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
---
 pw_rpc/server.cc | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/pw_rpc/server.cc b/pw_rpc/server.cc
index d7634ab6ba..bb1aefd89c 100644
--- a/pw_rpc/server.cc
+++ b/pw_rpc/server.cc
@@ -74,6 +74,10 @@ Status Server::ProcessPacket(ConstByteSpan packet_data,
           .IgnoreError();
     }
     internal::rpc_lock().unlock();
+    PW_LOG_DEBUG("Received packet on channel %u for unknown RPC %08x/%08x",
+                 static_cast<unsigned>(packet.channel_id()),
+                 static_cast<unsigned>(packet.service_id()),
+                 static_cast<unsigned>(packet.method_id()));
     return OkStatus();  // OK since the packet was handled.
   }
 
@@ -142,6 +146,12 @@ void Server::HandleClientStreamPacket(const internal::Packet& packet,
     channel.Send(Packet::ServerError(packet, Status::InvalidArgument()))
         .IgnoreError();  // Errors are logged in Channel::Send.
     internal::rpc_lock().unlock();
+    PW_LOG_DEBUG(
+        "Received client stream packet for %u:%08x/%08x, which doesn't have a "
+        "client stream",
+        static_cast<unsigned>(packet.channel_id()),
+        static_cast<unsigned>(packet.service_id()),
+        static_cast<unsigned>(packet.method_id()));
     return;
   }
 
@@ -149,6 +159,12 @@ void Server::HandleClientStreamPacket(const internal::Packet& packet,
     channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()))
         .IgnoreError();  // Errors are logged in Channel::Send.
     internal::rpc_lock().unlock();
+    PW_LOG_DEBUG(
+        "Received client stream packet for %u:%08x/%08x, but its client stream "
+        "is closed",
+        static_cast<unsigned>(packet.channel_id()),
+        static_cast<unsigned>(packet.service_id()),
+        static_cast<unsigned>(packet.method_id()));
     return;
   }