From e99645b951cd8676de7ae8735ece5b5fedfc6d90 Mon Sep 17 00:00:00 2001 From: Mohamed Elrakad Date: Fri, 23 Aug 2024 09:17:32 +0000 Subject: [PATCH] Fix a bug in the Android Jank CUJs Perfetto plugin. The plugin was showing null CUJ names that don't have a status. as concatenating null to the name results in null. Change-Id: Id66166ecc5f2bc652f6ce7b9088c71c4dcc7edce Bug: 361724078 --- ui/src/plugins/dev.perfetto.AndroidCujs/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/plugins/dev.perfetto.AndroidCujs/index.ts b/ui/src/plugins/dev.perfetto.AndroidCujs/index.ts index dd05809907..b733cce79b 100644 --- a/ui/src/plugins/dev.perfetto.AndroidCujs/index.ts +++ b/ui/src/plugins/dev.perfetto.AndroidCujs/index.ts @@ -110,7 +110,7 @@ const JANK_CUJ_QUERY = ` ) ) THEN ' ✅ ' - ELSE NULL + ELSE ' ❓ ' END || cuj.name AS name, total_frames, missed_app_frames, @@ -162,7 +162,7 @@ const LATENCY_CUJ_QUERY = ` cuj_state_marker.ts >= cuj.ts AND cuj_state_marker.ts + cuj_state_marker.dur <= cuj.ts + cuj.dur AND marker_track.name = cuj.name AND ( - cuj_state_marker.name GLOB 'cancel' + cuj_state_marker.name GLOB 'cancel' OR cuj_state_marker.name GLOB 'timeout') ) THEN ' ❌ '