From 7b927e17a9d374c17b2c1a8b0fcb9610e54028a7 Mon Sep 17 00:00:00 2001
From: Steve Golton <stevegolton@google.com>
Date: Fri, 23 Aug 2024 14:31:43 +0100
Subject: [PATCH] ui: Remove unused track-decider related types from various
 plugins

Several types were defined and exported but never used.

Some of the interfaces these types depend on (`AddTrackArgs`) are going
away soon, so this CL just removes the unused types.

Change-Id: I34ebf54bc5733591a8dc4e74be79fc3a083d0795
---
 ui/src/core_plugins/chrome_scroll_jank/common.ts | 5 -----
 ui/src/core_plugins/chrome_scroll_jank/index.ts  | 8 +-------
 ui/src/core_plugins/screenshots/index.ts         | 5 -----
 3 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/ui/src/core_plugins/chrome_scroll_jank/common.ts b/ui/src/core_plugins/chrome_scroll_jank/common.ts
index d3eeb15a92..cefbed8515 100644
--- a/ui/src/core_plugins/chrome_scroll_jank/common.ts
+++ b/ui/src/core_plugins/chrome_scroll_jank/common.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {AddTrackArgs} from '../../common/actions';
 import {ObjectByKey} from '../../common/state';
 import {featureFlags} from '../../core/feature_flags';
 import {CustomSqlDetailsPanelConfig} from '../../frontend/tracks/custom_sql_table_slice_track';
@@ -24,10 +23,6 @@ export const ENABLE_CHROME_SCROLL_JANK_PLUGIN = featureFlags.register({
   defaultValue: false,
 });
 
-export type DecideTracksResult = {
-  tracksToAdd: AddTrackArgs[];
-};
-
 export interface ScrollJankTrackSpec {
   key: string;
   sqlTableName: string;
diff --git a/ui/src/core_plugins/chrome_scroll_jank/index.ts b/ui/src/core_plugins/chrome_scroll_jank/index.ts
index 55ed77623f..bfcbd43b32 100644
--- a/ui/src/core_plugins/chrome_scroll_jank/index.ts
+++ b/ui/src/core_plugins/chrome_scroll_jank/index.ts
@@ -15,7 +15,6 @@
 import {v4 as uuidv4} from 'uuid';
 
 import {uuidv4Sql} from '../../base/uuid';
-import {DeferredAction} from '../../common/actions';
 import {generateSqlWithInternalLayout} from '../../common/internal_layout_utils';
 import {featureFlags} from '../../core/feature_flags';
 import {GenericSliceDetailsTabConfig} from '../../frontend/generic_slice_details_tab';
@@ -33,7 +32,7 @@ import {
 import {Engine} from '../../trace_processor/engine';
 
 import {ChromeTasksScrollJankTrack} from './chrome_tasks_scroll_jank_track';
-import {DecideTracksResult, ENABLE_CHROME_SCROLL_JANK_PLUGIN} from './common';
+import {ENABLE_CHROME_SCROLL_JANK_PLUGIN} from './common';
 import {EventLatencySliceDetailsPanel} from './event_latency_details_panel';
 import {EventLatencyTrack, JANKY_LATENCY_NAME} from './event_latency_track';
 import {ScrollDetailsPanel} from './scroll_details_panel';
@@ -49,11 +48,6 @@ const ENABLE_SCROLL_JANK_PLUGIN_V2 = featureFlags.register({
   defaultValue: false,
 });
 
-export type ScrollJankTrackGroup = {
-  tracks: DecideTracksResult;
-  addTrackGroup: DeferredAction;
-};
-
 class ChromeScrollJankPlugin implements PerfettoPlugin {
   async onTraceLoad(ctx: PluginContextTrace): Promise<void> {
     if (ENABLE_CHROME_SCROLL_JANK_PLUGIN.get()) {
diff --git a/ui/src/core_plugins/screenshots/index.ts b/ui/src/core_plugins/screenshots/index.ts
index c116299f1e..a1bacdeddb 100644
--- a/ui/src/core_plugins/screenshots/index.ts
+++ b/ui/src/core_plugins/screenshots/index.ts
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 import {uuidv4} from '../../base/uuid';
-import {AddTrackArgs} from '../../common/actions';
 import {GenericSliceDetailsTabConfig} from '../../frontend/generic_slice_details_tab';
 import {
   BottomTabToSCSAdapter,
@@ -26,10 +25,6 @@ import {
 import {ScreenshotTab} from './screenshot_panel';
 import {ScreenshotsTrack} from './screenshots_track';
 
-export type DecideTracksResult = {
-  tracksToAdd: AddTrackArgs[];
-};
-
 class ScreenshotsPlugin implements PerfettoPlugin {
   async onTraceLoad(ctx: PluginContextTrace): Promise<void> {
     const res = await ctx.engine.query(`