From d6ac03ff9b62f889b143a691e1a913395db84f87 Mon Sep 17 00:00:00 2001 From: Daniele Di Proietto Date: Fri, 15 Nov 2024 11:59:28 +0000 Subject: [PATCH] heapprofd: Fix outdated log message At the beginning, heapprofd could work in two modes on android: * Central, where each app connects to the central heapprofd daemon. * Fork, where each app starts its own heapprofd daemon. On android user builds, only fork mode was supported. An app would try to connect to the central heapprofd daemon, it would fail and then it would start its own heapprofd daemon in fork mode. The log message made sense. Then, central mode started to be supported on user builds and fork mode was removed on android. Since https://r.android.com/1536299, the log message doesn't make sense anymore. Change-Id: I5e53953329c57447e3a69c3cabd4ce9b891496ce --- src/profiling/memory/client_api_factory_android.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/profiling/memory/client_api_factory_android.cc b/src/profiling/memory/client_api_factory_android.cc index 9c7b63c60a..fe5318fc1c 100644 --- a/src/profiling/memory/client_api_factory_android.cc +++ b/src/profiling/memory/client_api_factory_android.cc @@ -46,7 +46,7 @@ std::shared_ptr ConstructClient( std::optional sock = Client::ConnectToHeapprofd(perfetto::profiling::kHeapprofdSocketFile); if (!sock) { - PERFETTO_ELOG("Failed to connect to %s. This is benign on user builds.", + PERFETTO_ELOG("Failed to connect to %s.", perfetto::profiling::kHeapprofdSocketFile); return nullptr; }