fix: sort sbom packages by PURL #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
- Coverage 68.53% 68.53% -0.01%
==========================================
Files 175 175
Lines 16804 16807 +3
==========================================
+ Hits 11516 11518 +2
- Misses 4661 4662 +1
Partials 627 627 ☔ View full report in Codecov by Sentry. |
|
As part of doing this I looked into trying to ensure everything is sorted as part of output processing but I found:
In hindsight, it's probably overall better to try and avoid as much sorting as possible in |
hogo6002
approved these changes
Oct 1, 2024
another-rex
approved these changes
Oct 3, 2024
another-rex
pushed a commit
that referenced
this pull request
Oct 17, 2024
While from what I understand duplicates should not be possible in a valid SBOM, apparently they happen and it's useful for us to report + skip them. Since doing this efficiently requires use of a map we in turn have to sort the packages to ensure a consistent output order, leading to me discovering that we're not already sorting the packages - I've opened #1288 to land that change first. Resolves #330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both ensures the output is consistent for tests and I think is better for readability as it means packages end up grouped by their ecosystem