Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS support #1110

Open
czcollier opened this issue Nov 19, 2024 · 4 comments · May be fixed by #1109
Open

CORS support #1110

czcollier opened this issue Nov 19, 2024 · 4 comments · May be fixed by #1109

Comments

@czcollier
Copy link

Applications built with Mesop should be embeddable into pages on external sites. AI (especially chat) UIs are prime candidates for embedding into host websites.

To enable this, CORS support will need to be added.

CORS can be added to Mesop relatively simply by copying the pattern used for Iframe Security. Iframe Security (SecurityPolicy) and CORS have similar use cases and implementations. Both of these mechanisms are implemented using HTTP response headers, and configuration via @me.page parameters make sense as a configuration mechanism.

I have a preliminary PR here: #1109
@czcollier czcollier linked a pull request Nov 19, 2024 that will close this issue
Draft
@wwwillchen
Copy link
Collaborator

If you want to embed a Mesop app on another website, you shouldn't need to modify CORS. As you've linked to, the iframe security allows other sites to embed the Mesop app.

Are you embedding a Mesop app in another way besides iframes?

@czcollier
Copy link
Author

czcollier commented Nov 20, 2024 •
edited
Loading

Hi, thanks for reviewing. Yes, we are embedding via Javascript (XmlHttpRequest, AJAX). This is another common way of embedding into websites. For example, Vertex AI Agent Builder has options for Iframe or "widget" embedding. See the attached screenshot showing the agent builder UI. We would be implementing functionality similar to this, where our app could be embedded via JS.

Image

@wwwillchen
Copy link
Collaborator

I see - thanks for sharing. In your PR #1109 can you add a minimal example of how a web page would embed a Mesop app? This would also be helpful for adding an e2e test to make sure this functionality is working as expected.

@czcollier
Copy link
Author

Yes, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First pass at implementing cors czcollier/mesop
2 participants
@czcollier @wwwillchen