Upgrade pulldown-cmark and pulldown-cmark-to-cmark #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kdarkhan
commented
Jun 24, 2024
kdarkhan
commented
- pulldown-cmark/[email protected]
- Byron/[email protected]
kdarkhan
force-pushed
the
upgrade-pulldown-cmark
branch
3 times, most recently
from
d03cf51 to
4aea295
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 13 13
Lines 3138 3138
Branches 3138 3138
=======================================
Hits 2809 2809
Misses 236 236
Partials 93 93 ☔ View full report in Codecov by Sentry. |
kdarkhan
force-pushed
the
upgrade-pulldown-cmark
branch
from
4aea295 to
edce6ad
Compare
kdarkhan
commented
Jun 24, 2024
| @@ -1,2 +0,0 @@ | |||
| # https://github.com/rust-lang/rustfmt/issues/4991 | |||
| imports_granularity = "Module" | |||
There was a problem hiding this comment.
Nightly cargofmt is failing dprint check due to printing to stderr strings like rewriting static. It does not seem to introduce any diff in formatting but dprint github action seems to get confused by those logs.
I adjusted the action to use stable cargofmt and it seems to produce no diff either. So maybe we can switch to stable version? @mgeisler
There was a problem hiding this comment.
Yeah, this is fine for now! The reason we don't see any diff is that the default is Preserve.
mgeisler
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.