Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of go mod tidy causes downstream issues #327

Open
rdmoore opened this issue Jan 5, 2022 · 0 comments · May be fixed by #344
Open

Lack of go mod tidy causes downstream issues #327

rdmoore opened this issue Jan 5, 2022 · 0 comments · May be fixed by #344

Comments

@rdmoore
Copy link

rdmoore commented Jan 5, 2022

Version: v3.2.1

Problem

go.mod file includes google.golang.org/grpc/cmd/protoc-gen-go-grpc but does not need it. This causes an issue with go list when V3.2.1 is used in another repo.

Solution

run go mod tidy prior to release.

Details

Updating my repository to use google.golang.org/[email protected] caused a strange and unexpected error. My go.sum file ends up with a dependency on google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod

This causes an issue in my repo when running the following command:

go list google.golang.org/grpc/...

I think this is due to an issue with one of the Go commands - e.g., go mod tidy or go list. But after forking this repo and running go mod tidy the dependency to protoc-gen-go-grpc is removed from martian and then from my repo once I run go mod tidy there. And the go list command works again.

@nohajc nohajc linked a pull request Jul 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant