Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental compilation / processing issue #2031

Closed
bitspittle opened this issue Aug 14, 2024 · 2 comments
Closed

Incremental compilation / processing issue #2031

bitspittle opened this issue Aug 14, 2024 · 2 comments

Comments

@bitspittle
Copy link
Contributor

To repro, we'll build a Kobweb website, which uses KSP behind the scenes to parse a project and discover all website pages.

Important

When you're done with the below steps, run ../gradlew kobwebStop! Otherwise, the web server will keep running.

You will want two terminal windows open for this one -- one will be consumed by Gradle.

Terminal 1

  • git clone https://github.com/varabyte/kobweb-site && cd kobweb-site/site
  • git checkout feature/dt/test-ksp-1
  • Run ../gradlew kobwebStart -t
  • In a browser, visit http://localhost:8080/docs/tutorials/create-a-page and make sure something renders

Terminal 2

If not reproduced...

Sometimes the issue doesn't always happen the first time; in that case, let's keep going. Still in terminal 2...

Important

When you're done with the above steps, run ../gradlew kobwebStop! Otherwise, the web server will keep running.


Note that this may be resolved by the fix to #2027 but it's possibly worth checking in case it's a separate issue.

@bitspittle
Copy link
Contributor Author

For context on what's happening, note that this site creates its pages in markdown. Those markdown files get converted at compile time into Kotlin code, and it's that Kotlin code which should be picked up by the KSP processing step.

When switching between branches, CreateAPage.md exists in test-ksp-1 and GettingKobweb.md exists in test-ksp-2.

@bitspittle
Copy link
Contributor Author

We believe this ins't happening anymore with latest KSP so we're closing. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant