Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Switch Topic and PullSubscription to use normal pubsub client #1739

Closed
grantr opened this issue Sep 18, 2020 · 1 comment · Fixed by #1761
Closed

Switch Topic and PullSubscription to use normal pubsub client #1739

grantr opened this issue Sep 18, 2020 · 1 comment · Fixed by #1761
Assignees
Labels
area/sources kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. priority/2 Nice to have feature but doesn't block current release defined by release/*
Milestone

Comments

@grantr
Copy link
Contributor

grantr commented Sep 18, 2020

Problem
Topic and PullSubscription reconcilers still use the gpubsub client, making their tests different from the Broker and Trigger tests which use pstest. It would be nice, especially for horizontal features like #1678, if the tests used similar helpers.

Exit Criteria
Topic and PullSubscription reconciler code stop using gpubsub, and tests use pstest.

Related to #1430.

/cc @nachocano @Harwayne @zhongduo

@grantr grantr added kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. area/sources labels Sep 18, 2020
@zhongduo zhongduo self-assigned this Sep 21, 2020
@grantr grantr added the priority/2 Nice to have feature but doesn't block current release defined by release/* label Sep 22, 2020
@grantr grantr added this to the Backlog milestone Sep 22, 2020
@zhongduo
Copy link
Contributor

gpubsub has a way to inject errors in a normal client call, eg create new topic or deleting a topic, this is currently not supported in pstest, so we will be missing some tests of server error handling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/sources kind/cleanup Internal cleanup (tech debt, etc) without customer impact, but affects developer velocity. priority/2 Nice to have feature but doesn't block current release defined by release/*
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants