Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VFS Tracer broke #47

Open
SamB opened this issue May 26, 2022 · 1 comment
Open

VFS Tracer broke #47

SamB opened this issue May 26, 2022 · 1 comment

Comments

@SamB
Copy link

SamB commented May 26, 2022

Worse, the error message is unreadable (the text is confined to an itty-bitty square somehow). However, thanks to the UI Inspector, I can recover the HTML for the error message. (The whitespace was somewhat mangled, so I've tweaked it.)

<html>
   <head>
     <style type="text/css">
       <!--
         body { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         div { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         td { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         p { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
         a { font-family: Segoe UI; font-size: 12pt; color: #ede891 }
         code { font-size: 12pt }
         ul { list-style: disc; margin-left: 15px }
       -->
     </style>
   </head>
   <body>
     Detected a breaking change. Cannot find
      com.intellij.psi.stubs.StubIndexImpl::createPsiNoLock.
   </body>
 </html>

However, it seems that this instance of createPsiNoLock is a copy and paste error: the method in question is actually named processElements:

ide-perf/src/main/java/com/google/idea/perf/vfstracer/VirtualFileTracer.kt

Line 252 in 3610383

if (name != "processElements" || descriptor != "(Lcom/intellij/psi/stubs/StubIndexKey;Ljava/lang/Object;Lcom/intellij/openapi/project/Project;Lcom/intellij/psi/search/GlobalSearchScope;Lcom/intellij/util/indexing/IdFilter;Ljava/lang/Class;Lcom/intellij/util/Processor;)Z") {

It looks like this got moved to com.intellij.psi.stubs.StubIndexEx#processElements in commit
JetBrains/intellij-community@7aa4148.
@SamB SamB changed the title Vfs tracer broke VFS Tracer broke May 26, 2022
@gharrma
Copy link
Collaborator

gharrma commented Jun 1, 2022

Thank you for the very detailed report! I'll try to get to this soon. It looks like an easy fix, but I also want to add some test coverage for the VFS tracer (currently there is very little).

p.s. the VFS tracer is relatively experimental and hasn't received very much usage yet. So if you have used it in the past, please let me know how it went / whether it was useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamB @gharrma