-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pseudo-xrefs for implicitly imported entities #100
Comments
Re "no trivial span to put these":That's true, but one could pack an existing span (say the module name span), given a good UI that can handle that. Re "how is this useful":One usecase I can think of is showing "imported via" info on the UI. Sometimes, if there are many implicit imports, it is not clear which one imports a given name. If the ref/imports is available on the file, the UI could reconstruct that info. OTOH if the exported name list is long (maybe auto-generated stuff from protos), this would be quite a burden, and need limiting... I would say if someone cares (maybe CodeUnderhood one day), they should implement this. |
Re the "imported via" feature: I think that is solvable even without having the implicit import refs. One could query the reverse- |
Inspired by TreeTide/underhood#10, I believe we should consider
Why do I think this is a better alternative than letting the frontend calculate the imported-via info itself?
Implementation Note: this can be implemented purely in the kythe-frontend, shouldn't affect GHC traversal. |
Related to #6 and #97.
#97 adds xrefs for explicit imports but not for implicit ones.
The text was updated successfully, but these errors were encountered: