Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: use read(2) host syscall to perform read on disk-backed MemoryFiles #11163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawei-sdw
Copy link
Contributor

The mf.MapInternal()+safemem.CopySeq() approach used right now incurs a lot of page faults without page population. Page-by-page faults incurs a lot of context switching. This commits uses read(2) host syscall instead, which makes one context switch and faults all the pages that are touched during the read.

…yFiles

The mf.MapInternal()+safemem.CopySeq() approach used right now incurs a lot of
page faults without page population. Page-by-page faults incurs a lot of context
switching. This commits uses read(2) host syscall instead, which makes one context
switch and faults all the pages that are touched during the read.

Signed-off-by: Dawei Shen <[email protected]>
@ayushr2
Copy link
Collaborator

ayushr2 commented Nov 11, 2024

Thanks for the change! I think this is a complimentary change to 0d52b50. In that commit description, you will see that I attached the FIO benchmark results. Could you also attach FIO read benchmark results?

cc @nixprime

@dawei-sdw
Copy link
Contributor Author

Thanks for the change! I think this is a complimentary change to 0d52b50. In that commit description, you will see that I attached the FIO benchmark results. Could you also attach FIO read benchmark results?

cc @nixprime

Thank you very much for your comments; it is a very helpful suggestion. I will attach the FIO read benchmark results for reference to commit 0d52b50.

@ayushr2
Copy link
Collaborator

ayushr2 commented Nov 12, 2024

I will attach the FIO read benchmark results for reference to commit 0d52b50.

I mean could you attach FIO benchmark results in the description of this PR? So it is part of git commit history once this is merged.

@dawei-sdw
Copy link
Contributor Author

I will attach the FIO read benchmark results for reference to commit 0d52b50.

I mean could you attach FIO benchmark results in the description of this PR? So it is part of git commit history once this is merged.

Sure, I will attach the FIO benchmark results in the commit log of this PR. I haven't researched the FIO benchmark yet, so I will need to look into it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants