-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is guice project dead? #1643
Comments
It is active - and in use, by everything on google, including google play so.... What happens is the codebase is on their side and the public repo is a copy of it - But once deployed the PR is closed - With your PR though, you're altering the binding sequence, it will have massive consequences and there are easily over 200000 apps that must be regression tested with it on the base repo, honestly you should probably just check the sequencing and not build the binders across threads, that's very bad practice Otherwise, shade and make your changes on your side - |
Would be nice if the team would give a sign of life on the PR.
Good to know someone tests things too.
Would be great if you would give us some hint on the PR what direction the fix should go.
Are we talking about same PR? Do you mean our application or the proposed fix in #1635? Anyway, thanks for the feedback, the question here is answered and I would be glad to continue discussion with a real human on the PR #1635. |
I don't see any recent activity on the project, at least not in the public github repo.
I've asked multiple times for a feedback for #1635 but with no reaction.
The last commit 7014486 (created by a bot) approved by a human (@andrewthehan) was on 29 June and that corrected the copyright year.
The last commit crafted by a human (@sameb) e0f1216 was on 22 February.
If this project is not dead, could some human, being left with commit rights on this project, take a look at #1635?
Thank you.
The text was updated successfully, but these errors were encountered: