-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GWT (since Guava 19): Missing java.lang.Lang inherits in java.util.Util #2638
Comments
Thanks. I figured this was what was going on in http://stackoverflow.com/questions/40360901/gwt-2-8-throws-exception-when-compiling-with-guava-20, but I'd been hoping the original poster would get back to me. We'll fix this. |
That was my first guess, as well. After looking, though, I think it's for |
This will be fixed in the next Guava release. In the meantime, you can manually add |
I think it's fine to document it on the Guava 19 / 20 release notes as a known issue and publish the fix with 21.0. Btw: It's likely that GWT will provide CompletableFuture emulation in the future, thus also emulating most if not all java.util.concurrent classes Guava currently provides. I am just curious but is there a reason why you guys don't contribute reasonable implemented JRE emulation to GWT itself? |
We've talked to GWT about this on occasion. Part of the question is what the Broadly speaking, we're happy to contribute whatever we can to GWT. |
I'm thinking "by the end of the month" for 21.0, FWIW. I suppose that means an RC next week. Is truth8-gwt out in a release yet? I suppose we could depend on a snapshot for a RC if not. Should also check with others if there's anything else we feel needs to happen before 21.0. |
I don't think we have truth8-gwt yet. I guess we'll want to poke cgruber again soon. |
Starting with Guava 19 emulations of
java.util.concurrent.Future/CountDownLatch
have been added and a matchingjava.util.Util.gwt.xml
has been added to publish the super source. Both classes depend onjava.lang.InterruptedException
which has been super sourced as well usingjava.lang.Lang.gwt.xml
.However
java.util.Util.gwt.xml
does not inheritjava.lang.Lang.gwt.xml
so the GWT compiler generally does not see super source ofjava.lang.InterruptedException
if you would only inheritUtil.gwt.xml
in a GWT app.Basically if a GWT app does not directly or indirectly inherit
Collect.gwt.xml
(the only module that actually inheritsLang.gwt.xml
) GWT compilation fails as nearly everything pulls inBase.gwt.xml
which in turn pulls inUtil.gwt.xml
.Also I am not so sure why
Base.gwt.xml
pulls inUtil.gwt.xml
as the code in the base package does not seem to depend on anything from java.util.concurrent, but maybe that's because inside Google you have more code covered throughBase.gwt.xml
.So please revisit and fix your inherits structure for GWT.
The text was updated successfully, but these errors were encountered: