From f011fa3ae9628ed72eeec6095cf8b9c0813317e7 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 9 Oct 2024 21:56:03 -0700 Subject: [PATCH] feat!: Support Node 18+ (#896) * feat!: Support Node 18+ Drop Support for older versions of Node.js * chore: skip windows kitchen sink until #897 --- .github/workflows/ci.yaml | 10 +++++----- .github/workflows/release.yaml | 2 +- package-lock.json | 2 +- package.json | 2 +- test/kitchen.ts | 4 +++- 5 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1e47eb1d..c52fe15b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ jobs: strategy: fail-fast: false matrix: - node: [14, 16, 18, 20, 21] + node: [18, 20, 22] steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 @@ -29,7 +29,7 @@ jobs: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 18 - run: npm ci - run: npm run system-test system_test: @@ -38,7 +38,7 @@ jobs: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 18 - run: npm ci - run: npm run system-test lint: @@ -47,7 +47,7 @@ jobs: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 18 - run: npm ci - run: npm run lint license_check: @@ -56,6 +56,6 @@ jobs: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 18 - run: npm ci - run: npm run license-check diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 22eda9c0..dd7bc41b 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 18 registry-url: 'https://wombat-dressing-room.appspot.com' - run: npm ci - run: npm publish diff --git a/package-lock.json b/package-lock.json index ce1cd876..bcb44ceb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -53,7 +53,7 @@ "typescript": "^5.4.3" }, "engines": { - "node": ">=14" + "node": ">=18" }, "peerDependencies": { "typescript": ">=3" diff --git a/package.json b/package.json index 817c4943..5b9a0914 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "fix": "eslint --fix '**/*.ts'" }, "engines": { - "node": ">=14" + "node": ">=18" }, "keywords": [ "typescript", diff --git a/test/kitchen.ts b/test/kitchen.ts index df1888e2..c39e4848 100644 --- a/test/kitchen.ts +++ b/test/kitchen.ts @@ -18,7 +18,9 @@ const execOpts = { encoding: 'utf8' as BufferEncoding, }; -describe('🚰 kitchen sink', () => { +const action = process.platform !== 'win32' ? describe : describe.skip; + +action('🚰 kitchen sink', () => { const fixturesPath = path.join('test', 'fixtures'); const gtsPath = path.join('node_modules', '.bin', 'gts'); const kitchenPath = path.join(stagingPath, 'kitchen');