[Code health] Replace mock with actual implementation in DataCollectionFragmentTest #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for unit tests
Will be used in unit tests
…ollectionFragmentTest
shobhitagarwal1612
requested review from
gino-m
and removed request for
scolsen
anandwana001
approved these changes
Dec 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2886 +/- ##
============================================
+ Coverage 61.59% 62.64% +1.04%
- Complexity 1176 1206 +30
============================================
Files 269 269
Lines 6364 6366 +2
Branches 878 878
============================================
+ Hits 3920 3988 +68
+ Misses 1899 1829 -70
- Partials 545 549 +4
|
shobhitagarwal1612
changed the title
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/home/HomeScreenViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2134
Towards #2840
Replaces mock implementation of SubmissionRepository with actual implementation in DataCollectionFragmentTest.
This improves the test coverage for SubmissionRepository by 60% and overall coverage by 1%.
Since this is a test-only change, so end-user behavior remains no-op.
@gino-m @anandwana001 PTAL?