Add OpenCensus tracing instrumentation in google-http-client module. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HailongWen
force-pushed
the
opencensus-instrumentation
branch
from
30e4166 to
9b542cf
Compare
|
Hi @mattwhisenhunt , would you please kindly help on this PR? |
bogdandrutu
reviewed
Jan 29, 2018
| * Sets the {@link TextFormat} used in context propagation. | ||
| * @param textFormat the text format. | ||
| */ | ||
| public static void setPropagationTextFormat(@Nullable TextFormat textFormat) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * Sets the {@link TextFormat.Setter} used in context propagation. | ||
| * @param textFormatSetter the {@code TextFormat.Setter} for the text format. | ||
| */ | ||
| public static void setPropagationTextFormatSetter(@Nullable TextFormat.Setter textFormatSetter) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * {@link TextFormat.Setter} for {@link activeTextFormat}. | ||
| */ | ||
| @Nullable | ||
| static TextFormat.Setter propagationTextFormatSetter = null; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -854,7 +865,9 @@ public HttpResponse execute() throws IOException { | |||
| Preconditions.checkNotNull(requestMethod); | |||
| Preconditions.checkNotNull(url); | |||
|
|
|||
| Span span = tracer.spanBuilder(traceSpanNamePrefix + "execute").startSpan(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| public static void propagateTracingContext(HttpHeaders headers) { | ||
| Preconditions.checkNotNull(headers); | ||
| if (propagationTextFormat != null && propagationTextFormatSetter != null) { | ||
| Span span = tracer.getCurrentSpan(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1057,6 +1076,7 @@ public HttpResponse execute() throws IOException { | |||
| } | |||
| } | |||
| } while (retryRequest); | |||
| span.end(OpenCensusUtils.getEndSpanOptions(response == null ? null : response.getStatusCode())); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -977,6 +992,8 @@ public HttpResponse execute() throws IOException { | |||
|
|
|||
| // execute | |||
| lowLevelHttpRequest.setTimeout(connectTimeout, readTimeout); | |||
| // switch tracing scope to current span | |||
| Scope ws = tracer.withSpan(span); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…r-plugin to v3.8.1 (googleapis#393)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenCensus-Java instrumentation in to monitor and record events when executing
HttpExecute#execute().The instrumentation starts a
Spanwhen the method begins, and is ended before the method exits. The status of the span will be determined according to the status of the response. ThisSpanis stored into local span store, and can be optionally exported if user explicitly configure an exporter (e.g. stackdriver exporter).Spans can have children. In this case, the generatedSpanin the instrumentation will be parent of all theSpans generated by server-side procedure. To link the childrenSpanwith their parent, the context information should be propagated to server side. This is done by using OpenCensus HTTP Util to inject the information into the header in the request.Added
OpenCensusUtilsprovides helper methods to perform context propagation, and setting end status of span.The added dependency of
opencensus-apicontains basic no-op implementation. It will be replaced by real implementation if user explicitly adds dependency ofopencensus-imploropencensus-impl-lite(for android and gae) in the classpath.This PR does not contain integration test when
opencensus-implis provided. It can be added with the help of maintainers.