-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make it webpackable #371
Conversation
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
Coverage ? 93.03%
=========================================
Files ? 17
Lines ? 1033
Branches ? 213
=========================================
Hits ? 961
Misses ? 72
Partials ? 0
Continue to review full report at Codecov.
|
I know you're on it, but I think we should make sure to include browser tests :) |
@JustinBeckwith One more look? :) |
Re: changelog From what I understand, for the basic usage of auth library, there should be no changes. Two functions were removed from I'm trying to prepare a webpacked version of google-api-nodejs-client with this latest state of auth library, I'll link it to this PR when it works. |
@alexander-fenster this is looking awesome. After you add details on the breaking changes to the description, I can approve this and we can start cranking on v3 💃 |
@JustinBeckwith I updated the PR description above. |
@alexander-fenster I'll let you do the honors of merging :) |
I. Cannot. Believe. It. Is. Merged. Thanks @JustinBeckwith :) |
Facing an issue after switching from webbbpackkk branch to latest release (actually, after axios -> gaxios) |
Let's discuss it there to keep the conversation in one place :) Thanks for your report! |
This currently does not work with Next.js. See: googleapis/google-auth-library-nodejs#449 googleapis/google-auth-library-nodejs#371
BREAKING CHANGE: This change makes
google-auth-library
OAuth2 functionality available for using in browsers (usingwebpack
).To reduce the bundle size, we use SubtleCrypto everywhere where Node.js
crypto
module is used. Since all SubtleCrypto methods return promises, we made two breaking changes toOAuth2Client
class:OAuth2Client.generateCodeVerifier
method has been replaced by the asynchronousasync generateCodeVerifierAsync
methodOAuth2Client.verifySignedJwtWithCerts
method has been replaced by theasync verifySignedJwtWithCertsAsync
method