Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to return raw input stream for response #1323

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Add option to return raw input stream for response #1323

merged 4 commits into from
Jun 18, 2019

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Jun 13, 2019

Add option to return raw input stream for response

@ajaaym ajaaym requested a review from a team as a code owner June 13, 2019 21:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2019
@ajaaym
Copy link
Contributor Author

ajaaym commented Jun 17, 2019

@chingor13 can you please review this, this is towards 3929

@ajaaym ajaaym requested a review from chingor13 June 17, 2019 14:22
chingor13
chingor13 requested changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with a few nits about the docs

...ent/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java Outdated Show resolved Hide resolved
...ent/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java Outdated Show resolved Hide resolved
...ent/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java Outdated Show resolved Hide resolved
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2019
@ajaaym ajaaym added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2019
@ajaaym
Copy link
Contributor Author

ajaaym commented Jun 18, 2019 •
edited
Loading

@chingor13 not sure whats going on with cla/google, can you check?

Edit: it worked fine after this comment. so its all good now.

@ajaaym ajaaym merged commit 7239425 into googleapis:master Jun 18, 2019
@chingor13 chingor13 mentioned this pull request Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajaaym @chingor13 @googlebot @kokoro-team