Extensible client options #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…lient. Introduces the builder pattern for these common configuration options so that it is extensible in the future.
chingor13
force-pushed
the
system-parameters
branch
from
62e32a4 to
1678fef
Compare
sduskis
added
needs work
chingor13
removed
the
needs work
|
Should this class use Auto-Value? |
We certainly could. We're not using autovalue yet for any of the other builders (or at all). It might make sense to come back with a refactoring PR to convert the all builders to use autovalue (if it's even possible). Otherwise, we will have a mix of several manually defined builders and one autovalue builder. WDYT? |
|
I'm not sold on trying to shoehorn autovalue in here. If we were starting from scratch, it would make a lot of sense. We cannot switch many of these implementations over to autovalue as they already have public constructors (including the |
sduskis
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the builder pattern for these common configuration options so that it is extensible in the future.
Add ability to configure
requestReasonanduserAgent.