Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-Goog-Api-Client header #1146

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Aug 8, 2018

To get better visibility into which Java versions/environments users are using, we want to add a header to all API requests that identify the client's language version (and other relevant environment versions).

See https://cloud.google.com/apis/docs/system-parameters

@chingor13 chingor13 requested a review from a team August 8, 2018 22:44
private static final String OS_VERSION = formatSemver(System.getProperty("os.version"));

private static String build(AbstractGoogleClient client) {
// TODO(chingor): add the API version from the generated client

This comment was marked as spam.

@chingor13 chingor13 merged commit 873e8d7 into googleapis:dev Aug 23, 2018
@chingor13 chingor13 deleted the api-version-header branch August 23, 2018 22:18
@chingor13 chingor13 mentioned this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants