-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for squashing images. #735
Conversation
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 79.43% 79.35% -0.08%
==========================================
Files 102 102
Lines 4668 4689 +21
==========================================
+ Hits 3708 3721 +13
- Misses 531 535 +4
- Partials 429 433 +4
Continue to review full report at Codecov.
|
First of all sorry for the long delay in responding. The change itself lgtm and I think there are some cool use cases it unlocks. So yay! The only nit I think is with the name If you're open to renaming (and you're still interested after all this time) I think we can merge this mostly as-is. |
This Pull Request is stale because it has been open for 90 days with |
I'd be happy to see this land, but I'm no longer with the company where I wanted this, so probably won't have the time to make changes. |
This is adapted from google#735 but changes the UX a bit to match what we've come to expect from crane. Add pkg/crane.Upload as well, for uploading a layer.
* Add crane flatten This is adapted from #735 but changes the UX a bit to match what we've come to expect from crane. Add pkg/crane.Upload as well, for uploading a layer. * ./hack/update-codegen.sh * Support --insecure in flatten * Make --platform work * Make flatten location-independent
No description provided.