Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for squashing images. #735

Closed
wants to merge 2 commits into from
Closed

Conversation

tomprince
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #735 into master will decrease coverage by 0.07%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   79.43%   79.35%   -0.08%     
==========================================
  Files         102      102              
  Lines        4668     4689      +21     
==========================================
+ Hits         3708     3721      +13     
- Misses        531      535       +4     
- Partials      429      433       +4     
Impacted Files Coverage Δ
pkg/v1/mutate/mutate.go 73.60% <61.90%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1a46d...54fcff5. Read the comment docs.

@imjasonh
Copy link
Collaborator

First of all sorry for the long delay in responding.

The change itself lgtm and I think there are some cool use cases it unlocks. So yay!

The only nit I think is with the name squash -- in other contexts where this has been done it's been called flatten, which I think is slightly more descriptive.

If you're open to renaming (and you're still interested after all this time) I think we can merge this mostly as-is.

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

Base automatically changed from master to main January 27, 2021 18:57
@github-actions github-actions bot closed this Feb 27, 2021
@tomprince
Copy link
Author

I'd be happy to see this land, but I'm no longer with the company where I wanted this, so probably won't have the time to make changes.

jonjohnsonjr added a commit to jonjohnsonjr/go-containerregistry that referenced this pull request Aug 11, 2021
This is adapted from google#735 but changes the UX a bit to match what we've
come to expect from crane.

Add pkg/crane.Upload as well, for uploading a layer.
@jonjohnsonjr jonjohnsonjr mentioned this pull request Aug 12, 2021
jonjohnsonjr added a commit that referenced this pull request Aug 12, 2021
* Add crane flatten

This is adapted from #735 but changes the UX a bit to match what we've
come to expect from crane.

Add pkg/crane.Upload as well, for uploading a layer.

* ./hack/update-codegen.sh

* Support --insecure in flatten

* Make --platform work

* Make flatten location-independent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants