authn/k8schain : fallthrough in case of gcloud command not available

[vdemeester]

It's not the prettiest change ever, but it keeps the error in the general case, but allows to fallthrough in a multikeychain. This type of errors could be used for other chains too 👼

It fixes cases where using google.Keychain with authn.NewMultiKeychain where gcloud command is not available (see https://gist.github.com/vdemeester/c397ffb3fd19b4cc2ba3243dc4db9f83). It should use Anonymous instead of failing hard in that case.

Signed-off-by: Vincent Demeester [email protected]

[codecov-io]

Codecov Report

Merging #405 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   54.18%   54.14%   -0.04%     
==========================================
  Files          87       87              
  Lines        4108     4111       +3     
==========================================
  Hits         2226     2226              
- Misses       1542     1544       +2     
- Partials      340      341       +1

Impacted Files	Coverage Δ
pkg/v1/google/auth.go	86.84% <0%> (-7.45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871d0d9...5253b29. Read the comment docs.

[jonjohnsonjr]

What does this fix?

[vdemeester]

@jonjohnsonjr I've updated the description (should also update the commit message I think) :

It fixes cases where using google.Keychain with authn.NewMultiKeychain where gcloud command is not available (see https://gist.github.com/vdemeester/c397ffb3fd19b4cc2ba3243dc4db9f83). It should use Anonymous instead of failing hard in that case.

[vdemeester]

@jonjohnsonjr updated 😉

[vdemeester]

@jonjohnsonjr updated 👼

[jonjohnsonjr]

LGTM but to reiterate pipelines shouldn't be depending on google.Keychain, removing that code should be safe :)

[vdemeester]

@jonjohnsonjr yes sir 🎖️ I'll update that on pipeline 😉