Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crane: Windows images failed to pull after pushing to local hosted Docker Registry instance #1980

Closed
laozc opened this issue Jul 18, 2024 · 2 comments · May be fixed by #1981
Closed

crane: Windows images failed to pull after pushing to local hosted Docker Registry instance #1980

laozc opened this issue Jul 18, 2024 · 2 comments · May be fixed by #1981
Labels
bug Something isn't working lifecycle/stale

Comments

@laozc
Copy link

laozc commented Jul 18, 2024

Describe the bug

Some Windows image derived from windows-host-process-container-base-image were not able to pull by containerd
after they were pushed to local hosted Docker Registry instance using crane.

To Reproduce

crane push windows-image.tar localhost:5000/imgetag:windows

containerd may report failure when pulling this image due to corrupted image content.

Expected behavior

The push should not resulted in corrupted image blob.
containerd should be able to pull the image.

Additional context

  • Output of crane version: main
  • Registry used (e.g., GCR, ECR, Quay)
    Docker Registry
@laozc laozc added the bug Something isn't working label Jul 18, 2024
@laozc
Copy link
Author

laozc commented Jul 18, 2024

Based on a further investigation on the issue,
we found that the base layer of windows-host-process-container-base-image is not gzip compressed

$ file blobs/sha256/f2784c8bc8525977aef9b6cd74e9a899274db7d82cd4b028e0ae049270927585 <= this is the base layer of windows-host-process-container-base-image
blobs/sha256/f2784c8bc8525977aef9b6cd74e9a899274db7d82cd4b028e0ae049270927585 POSIX tar archive (GNU)

$ file blobs/sha256/f1912f0046069c73564ef7d8cd9257698d5a9a2c4d4da8910dbb35e1865b3cb5 <= this is our layer to build upon windows-host-process-container-base-image
blobs/sha256/f1912f0046069c73564ef7d8cd9257698d5a9a2c4d4da8910dbb35e1865b3cb5: gzip compressed data, original size modulo 2^32 5632

This may break the image blob after the image gets uploaded to a remote registry.

@laozc laozc mentioned this issue Jul 18, 2024
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes detection if the image contains compressed layers laozc/go-containerregistry
1 participant
@laozc