Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Consider add concurrency and verbosity for remote.Catalog #1278

Closed
Dentrax opened this issue Feb 1, 2022 · 4 comments
Closed
Labels
enhancement New feature or request lifecycle/stale

Comments

@Dentrax
Copy link
Contributor

Dentrax commented Feb 1, 2022

I've just tried $ crane catalog command and it took so long that didn't even complete after several hours of run.

I think it would be great to add some concurrency model and some verbosity logs to check the current status of scan progress.

What do you think?

@Dentrax Dentrax added the question Further information is requested label Feb 1, 2022
@imjasonh imjasonh added enhancement New feature or request and removed question Further information is requested labels Feb 1, 2022
@imjasonh
Copy link
Collaborator

imjasonh commented Feb 1, 2022

I wonder if crane catalog should print each page as it's returned, instead of calling remote.Catalog which loads all pages into memory before returning.

edit: remote.CatalogPage seems like a good fit, but it doesn't return any information that would let it be fed into subsequent calls to CatalogPage 🤔

wdyt @jonjohnsonjr

@jonjohnsonjr
Copy link
Collaborator

My gut reaction is "please please don't ever use catalog" :)

You can throw a -v flag to print verbose logs.

@jonjohnsonjr
Copy link
Collaborator

I wonder if crane catalog should print each page as it's returned, instead of calling remote.Catalog which loads all pages into memory before returning.

We had some discussion around this originally but I think we just gave up.

#548

@github-actions
Copy link

github-actions bot commented May 3, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle/stale
Projects
None yet
Development

No branches or pull requests

3 participants