Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extras stored to describe capture device capabilities are used by replay #2101

Open
ben-clayton opened this issue Jul 30, 2018 · 0 comments
Open

Comments

@ben-clayton
Copy link
Contributor

ben-clayton commented Jul 30, 2018

As noted in this PR, there are a number of extras that are being stored into the capture to describe the traced device capabilities. These extras are then used to decide how to generate the replay.

This is all a bit backwards - we should no assumptions that the replay device is the same as the one used for tracing. If we need to dynamically generate replay logic based on the replay device capabilities, then we should be storing this information in the VulkanDriver structure of the device. By doing this, you'll get this information in the capture header as well as for the replay device.

There are already examples of this for GLES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants