Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow descriptors are not handled correctly #1784

Closed
Qining opened this issue Apr 10, 2018 · 0 comments · Fixed by #1785
Closed

Overflow descriptors are not handled correctly #1784

Qining opened this issue Apr 10, 2018 · 0 comments · Fixed by #1785
Assignees

Comments

@Qining
Copy link
Contributor

Qining commented Apr 10, 2018

https://github.com/google/gapid/blob/master/gapis/api/vulkan/vulkan.api#L5917
The binding numbers can be sparse and not consecutive, using len() as the maximum allowed binding + 1 is not correct.

https://github.com/google/gapid/blob/master/gapis/api/vulkan/vulkan.api#L5922
Bindings may not exist in the descriptor set, this can cause a crash in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant