Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support descent-override, ascent-override #6739

Open
oliviertassinari opened this issue Sep 20, 2023 · 2 comments
Open

Support descent-override, ascent-override #6739

oliviertassinari opened this issue Sep 20, 2023 · 2 comments
Labels
-- Needs Eng team opinion API related stuff only eng team can answer -- Needs manager's opinion from upper level I API / Website / Platform fonts.google.com related stuff I Request

Comments

@oliviertassinari
Copy link

Describe the issue

Font supports a couple of interesting features: https://web.dev/css-size-adjust/#ascent-override: descent-override, ascent-override however the Google Font API doesn't allow to take advantage of them.

To Reproduce

See how in https://developers.google.com/fonts/docs/css2 there are no options.

Context

The Roboto font usually doesn't feel vertically aligned under its default setting, e.g. mui/material-ui#29965. It can need descent-override.

@eliheuer
Copy link
Collaborator

eliheuer commented Sep 20, 2023

Thanks! I created a check in the Google Fonts QA system recently that looks for this kind of thing, so hopefully this will be less of an issue in the future.

It is not immediately clear to me why you can't customize descent-override with the Google Font CDN. A little bit more detail and context in this issue would help it move forward.

Maybe this is a dumb question, but why can't you do descent-override in the CSS independent of the Google Fonts API?

@eliheuer eliheuer added -- Needs manager's opinion from upper level -- Needs Eng team opinion API related stuff only eng team can answer labels Sep 20, 2023
@oliviertassinari
Copy link
Author

Maybe this is a dumb question, but why can't you do descent-override in the CSS independent of the Google Fonts API?

@eliheuer As I understand this CSS properties, it can only be added in the @font-face declaration but this one is owned by https://developers.google.com/fonts/docs/css2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Eng team opinion API related stuff only eng team can answer -- Needs manager's opinion from upper level I API / Website / Platform fonts.google.com related stuff I Request
Projects
None yet
Development

No branches or pull requests

3 participants