Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mingzat (SIL) #4514

Closed
Tracked by #4354
emmamarichal opened this issue Apr 15, 2022 · 5 comments · Fixed by #4721
Closed
Tracked by #4354

Add Mingzat (SIL) #4514

emmamarichal opened this issue Apr 15, 2022 · 5 comments · Fixed by #4721
Assignees
Labels
I New Font II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts
Milestone

Comments

@emmamarichal
Copy link
Collaborator

emmamarichal commented Apr 15, 2022

Font Project Git Repo URL:
https://github.com/silnrsi/font-mingzat

Super short description of the Font Family:
The Mingzat font supports the Lepcha script.

Fonts
Mingzat-Regular.ttf.zip

Capture d’écran 2022-06-01 à 16 35 06

@emmamarichal emmamarichal added this to the 2022 Q3 milestone Apr 15, 2022
@emmamarichal emmamarichal changed the title Add Mingzat Add Mingzat (SIL) Apr 15, 2022
@emmamarichal
Copy link
Collaborator Author

Fontbakery report

Fontbakery version: 0.8.9.dev3+gcf7de707

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[26] Mingzat-Regular.ttf
🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x2074 (SUPERSCRIPT FOUR)

    • 0x2212 (MINUS SIGN)

    • And 0x2215 (DIVISION SLASH)
      [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file does not match expected format: "lepcha glyph design copyright (c) 2001, glavyfonts and "
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "Lepcha glyph design copyright (c) 2001, GlavyFonts and copyright (c) 2006 Athinkra, LLC with Reserved Font Name "Lepcha".

    OpenType and Graphite code copyright (c) 2010-2019, SIL International (https://www.sil.org/) with Reserved Font Name "Mingzat".

    Latin glyph design copyright (c) 1994-2019, SIL International (https://www.sil.org/), with Reserved Font Names "SIL" and "Sophia".

This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://scripts.sil.org/OFL


SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007

PREAMBLE
The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others.

The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives.

DEFINITIONS
"Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation.

"Reserved Font Name" refers to any names specified as such after the copyright statement(s).

"Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s).

"Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment.

"Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software.

PERMISSION & CONDITIONS
Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions:

  1. Neither the Font Software nor any of its individual components, in Original or Modified Versions, may be sold by itself.

  2. Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user.

  3. No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder. This restriction only applies to the primary font name as presented to the users.

  4. The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software shall not be used to promote, endorse or advertise any Modified Version, except to acknowledge the contribution(s) of the Copyright Holder(s) and the Author(s) or with their explicit written permission.

  5. The Font Software, modified or unmodified, in part or in whole, must be distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software.

TERMINATION
This license becomes null and void if any of the above conditions are not met.

DISCLAIMER
THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]

  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • 🔥 FAIL Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/ [code: lacks-gasp]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Lepcha glyph design copyright (c) 2001, GlavyFonts and copyright (c) 2006 Athinkra, LLC. OpenType and Graphite code copyright (c) 2010-2019, SIL International (http://www.sil.org/). Latin glyph design copyright (c) 1994-2019, SIL International (http://www.sil.org/)." [code: bad-notice-format]
🔥 FAIL: Check glyphs do not have components which are themselves components. (com.google.fonts/check/glyf_nested_components)
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • uni1C291C2Dleft
    • uni1C291C2Eleft
    • uni1C291C2Fleft
    • uni1C291C30left
    • uni1C291C31left
    • uni1C291C32left
    • uni1C291C33left and uni1C291C35left [code: found-nested-components]
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: Name table entries should not contain line-breaks. (com.google.fonts/check/name/line_breaks)
  • 🔥 FAIL Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break. [code: line-break]
🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)
  • 🔥 FAIL OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['Mingzat-Regular.ttf']. [code: missing-os2-fsselection-bit7]
🔥 FAIL: Space and non-breaking space have the same width? (com.google.fonts/check/whitespace_widths)
  • 🔥 FAIL Space and non-breaking space have differing width: The space glyph named space is 500 font units wide, non-breaking space named (uni00A0) is 300 font units wide, and both should be positive and the same. GlyphsApp has "Sidebearing arithmetic" (https://glyphsapp.com/tutorials/spacing) which allows you to set the non-breaking space width to always equal the space width. [code: different-widths]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
WARN: Check name table: FULL_FONT_NAME entries. (com.google.fonts/check/name/fullfontname)
  • WARN [FULL_FONT_NAME(4):WINDOWS(3)]
    Got "Mingzat" which lacks "Regular", but it is probably OK in this case. [code: lacks-regular]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:
    • .null
    • uni1C301C36
    • nonmarkingreturn
    • uni1C2E1C36
    • uni1C2D1C36
    • uni1C331C36
    • uni1C311C36
    • uni1C321C36
    • uni1C281C35
    • And uni1C2F1C36
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni00AD	Contours detected: 1	Expected: 0
- Glyph name: uni25CC	Contours detected: 24	Expected: 16 or 12
- Glyph name: uniFFFC	Contours detected: 0	Expected: 22
- Glyph name: uni00AD	Contours detected: 1	Expected: 0
- Glyph name: uni25CC	Contours detected: 24	Expected: 16 or 12 
- And Glyph name: uniFFFC	Contours detected: 0	Expected: 22

[code: contour-count]

WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni034F (U+034F), uniFE00 (U+FE00), uniFE01 (U+FE01), uniFE02 (U+FE02), uniFE03 (U+FE03), uniFE04 (U+FE04), uniFE05 (U+FE05), uniFE06 (U+FE06), uniFE07 (U+FE07), uniFE08 (U+FE08) and 7 more.

Use -F or --full-lists to disable shortening of long lists. [code: mark-chars]

WARN: Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value (com.google.fonts/check/gpos_kerning_info)
  • WARN GPOS table lacks kerning information. [code: lacks-kern-info]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • uni1C02 (U+1C02): X=293.0,Y=1.0 (should be at baseline 0?)
    • uni1C03 (U+1C03): X=1044.0,Y=-1.0 (should be at baseline 0?)
    • uni1C07 (U+1C07): X=236.5,Y=-1.0 (should be at baseline 0?)
    • uni1C07 (U+1C07): X=338.0,Y=2.0 (should be at baseline 0?)
    • uni1C08 (U+1C08): X=578.0,Y=-1.0 (should be at baseline 0?)
    • uni1C0D (U+1C0D): X=868.0,Y=1.0 (should be at baseline 0?)
    • uni1C15 (U+1C15): X=776.0,Y=-1.0 (should be at baseline 0?)
    • uni1C17 (U+1C17): X=833.0,Y=-1.0 (should be at baseline 0?)
    • uni1C17 (U+1C17): X=310.0,Y=-1.0 (should be at baseline 0?)
    • uni1C21 (U+1C21): X=623.0,Y=1.0 (should be at baseline 0?) and 10 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:
    • uni1C21 (U+1C21): B<<348.0,355.0>-<449.0,447.0>-<447.0,447.0>>/B<<447.0,447.0>-<462.0,448.0>-<464.0,437.0>> = 3.8140748342903783
    • uni1C43 (U+1C43): B<<748.5,61.5>-<623.0,-3.0>-<440.0,-17.0>>/B<<440.0,-17.0>-<475.0,-23.0>-<521.5,-37.5>> = 14.102340832357056
    • uni1C43 (U+1C43): L<<728.0,-220.0>--<651.0,-276.0>>/B<<651.0,-276.0>-<652.0,-275.0>-<628.0,-265.0>> = 8.972626614896438 and uni1C4E (U+1C4E): L<<752.0,249.0>--<600.0,236.0>>/B<<600.0,236.0>-<611.0,238.0>-<611.5,238.0>> = 5.4164455206412905 [code: found-jaggy-segments]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
Mingzat-Regular.ttf
Dehinted Size 206.9kb
Hinted Size 206.9kb
Increase -24 bytes
Change -0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:
    • loca
    • GPOS
    • And GSUB [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO . [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 10 10 110 7 88 0
0% 4% 4% 49% 3% 39% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal self-assigned this Apr 15, 2022
@RosaWagner
Copy link
Contributor

Let's review these with SIL:
🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)
🔥 FAIL: Space and non-breaking space have the same width? (com.google.fonts/check/whitespace_widths)

@emmamarichal emmamarichal added the II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts label Apr 20, 2022
@RosaWagner
Copy link
Contributor

Space issue will be fixed in next release, so waiting for that next version to onbaord the font

@RosaWagner RosaWagner added -- Upstream is working on it Designer is making changes in the upstream repo and removed - Ready for Review labels Apr 20, 2022
@jvgaultney
Copy link

Agreed - thanks!

@jvgaultney
Copy link

Mingzat 1.100 has been released. It addresses both bit 7 and space width issues. It's ready to be onboarded now. Thanks!

https://github.com/silnrsi/font-mingzat/releases

@emmamarichal emmamarichal linked a pull request May 26, 2022 that will close this issue
@emmamarichal emmamarichal added - In Progress and removed -- Upstream is working on it Designer is making changes in the upstream repo labels May 26, 2022
@RosaWagner RosaWagner moved this from Todo to In Dev / PR Merged in Google Fonts Mar 9, 2023
@RosaWagner RosaWagner moved this from In Dev / PR Merged to Live in Google Fonts Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts
Projects
Status: Live
Development

Successfully merging a pull request may close this issue.

3 participants