-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fira Code - on deck to merge! #1460
Comments
I decided not to include this (#520) |
Oh, sorry, this is different. Fira Code (original, my repo) is a significantly different version that adds more than 100+ ligatures to Fira Mono, designed to improve how programs (code) looks on screen. It’s a big change and huge value added for programmers, compared to “just monospaced letters”. I released it Nov, 11 2014 and it’s been growing in popularity ever since. To date it’s the most popular programming font with ligatures (20k+ stars on GitHub) and it’s been the pioneer of that movement from the beginning, forcing IDEs to add support for it, for example (Atom, Idea, VS Code, iTerm 2, Sublime Text—none of them had it in 2014, and added ligatures support because of Fira Code pressure). You can browse through some feedback here: https://twitter.com/search?q=Fira%20Code&src=typd There’s been a long-standing request to get Fira Code on the web tonsky/FiraCode#18, and the Google Fonts is amongst most popular ones and easiest to use. Using ligatures on web is both possible and desirable, and hosted Fira Code would be the best way to do so. On names: on Oct 17, 2016 (2 years after my Fira Code release) Carrois released another version of Fira Mono, as you noticed, with altered line-height, which they unfortunately called Fira Code as well. As far as I know, nobody is very attached to that version of Fira Mono, either as a name or as a font. I hope my arguments convince you that Fira Code name is de facto associated with ligatures font, which I ask you to add in this issue. Please reconsider. And thank you for what you’re doing! Best, |
@davelab6
Yes, his comment above is also true. |
👆👆🏻👆🏼👆🏽👆🏾👆🏿 Fira Code is THE best font for code editing. Fira Mono doesn’t come close. Please reconsider |
Ligatures of Fira Code is very useful |
@tonsky made usable font for developers, i have been using it for year and half. it would be great for us developers to have it as google font so we can use it on posts and pages in code blocks. i'm supporting @tonsky 100% on this. also fira mono? why should i as developer use that instead of tonsky's font? |
Fira Code's ligatures is one of the best things that happened to my Haskell and JS development experience. I strongly support @tonsky on this. |
Thanks for all the context, everyone :) If there's real utility in this, I'm happy to add it - but, I would rather see this contributed upstream into Fira Mono proper. I heard that @carrois is working on a new version of the Fira font (https://github.com/bBoxType/FiraGO) but that currently has Mono/Code version as a future plan on the roadmap. @tonsky would you be willing to contribute your work upstream? :) |
I discussed that when I just started Fira Code, they didn’t want contributions back then (4 years ago), but had plans to reimplement that themselves. As you can see, they are still plans, Mono hasn’t changed much since then. I think they have different focus (Sans, not Mono) and lack of funding (it’s open font after all) which makes all changes in Fira really, really slow |
Why do you insist on using Fira Mono? Knowing the fact that Fira Code is far more active and better font than Fira Mono, also I couldn't even see a concrete roadmap on Fira Mono. Please elaborate. |
|
Bump! I love this font. It's easy to read and has been my go-to programming font for years, also, the included ligatures are a plus. |
I second this. |
@eriawan the product values include simplicity, and having lots of versions of the same typeface is confusing. When I first looked at this, I said line-space can be controlled on the web via CSS so there was no need for this. Now I am ok to add it because there is a value. |
@davelab6 |
We have permission from Mozilla to use Fira Mono, but not Fira Code. Maybe Mozilla can drop the RFN :) Also, I believe FiraGO has been funded, per the legal details in that README :) |
For this reason, I think it's reasonable for Google to reconsider adding this as its own font. Who wants to wait around forever for this? |
I’m currently awaiting reply from Mozilla, but they don’t seem to be very responsive. Contact email is dead too :( |
Fira Code for the win! |
The rfn is removed so this can be added
|
@davelab6 Given the RFN removal, is there any new traction on getting this added? |
Woops... so ugly this |
@JavierSegoviaCordoba I use https://userstyles.org/styles/37035/github-dark for dark mode on GitHub, and it also makes choosing the font easy. Just enter whatever version of Fira Code you have installed on your OS into the "Code Font" field under "Customize Settings" (in my case, it's "Fira Code Regular"), and you're good to go. |
Hi, I wonder if there's a plan on adding Fira Code to Google Fonts. Thx! |
Any chance this will be added in the next few weeks? I'd like to use FiraCode for my Monaco editor instances, and ideally source my fonts from Google fonts. |
bump. anything on this? |
Anyway we can help with this ? Testing or something ? |
We will add it soon. We've been developing testing and comparison tools to
help accelerate our font onboarding and update processes.
|
@davelab6 Wait, is the RFN really removed? https://github.com/mozilla/Fira/blob/master/LICENSE#L1 currently includes:
|
Yes, but the pr (mozilla/Fira#219) wasn't merged, but the rfn was cleared to be removed. |
Awesome, thanks for letting me know! |
Fira Code is QAed and ready to merge, but is currently blocked by mozilla/Fira#219. If folks come across this who would like to see Fira Code on Google Fonts, go upvote that PR. |
The PR above has been merged recently 🎉 |
How long do things typically remain on deck to merge before they actually get merged? |
Its like I can hear the machinery turning in the distance. |
The fact that this no-brainer has so far taken 1 year 4 months 18 days and 23 hours, and still isn't done, is quite depressing. :( |
Uhh, why was this closed? It surely isnt because it was added, since https://fonts.google.com/?query=Fira+Code return no results :( EDIT: I seem to miss the ability to read. It just seems as if the cache hasnt been updated |
Usually GitHub bugs are closed when the repository has the issue fixed, not when the fix is actually deployed. |
yes, I didn't realize that the thing had been added Pardon my stupidity |
Now online https://fonts.google.com/specimen/Fira+Code. thank you @tonsky and @thundernixon |
https://github.com/tonsky/FiraCode
please. Let me know if you need something changed/altered
The text was updated successfully, but these errors were encountered: