Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fira Code - on deck to merge! #1460

Closed
tonsky opened this issue Feb 25, 2018 · 42 comments · Fixed by #1911
Closed

Add Fira Code - on deck to merge! #1460

tonsky opened this issue Feb 25, 2018 · 42 comments · Fixed by #1911
Assignees

Comments

@tonsky
Copy link

tonsky commented Feb 25, 2018

https://github.com/tonsky/FiraCode

please. Let me know if you need something changed/altered

@davelab6
Copy link
Member

I decided not to include this (#520)

@davelab6 davelab6 added this to the Add New Families milestone Feb 25, 2018
@tonsky
Copy link
Author

tonsky commented Feb 26, 2018

Oh, sorry, this is different.

Fira Code (original, my repo) is a significantly different version that adds more than 100+ ligatures to Fira Mono, designed to improve how programs (code) looks on screen. It’s a big change and huge value added for programmers, compared to “just monospaced letters”.

I released it Nov, 11 2014 and it’s been growing in popularity ever since. To date it’s the most popular programming font with ligatures (20k+ stars on GitHub) and it’s been the pioneer of that movement from the beginning, forcing IDEs to add support for it, for example (Atom, Idea, VS Code, iTerm 2, Sublime Text—none of them had it in 2014, and added ligatures support because of Fira Code pressure). You can browse through some feedback here: https://twitter.com/search?q=Fira%20Code&src=typd

There’s been a long-standing request to get Fira Code on the web tonsky/FiraCode#18, and the Google Fonts is amongst most popular ones and easiest to use. Using ligatures on web is both possible and desirable, and hosted Fira Code would be the best way to do so.

On names: on Oct 17, 2016 (2 years after my Fira Code release) Carrois released another version of Fira Mono, as you noticed, with altered line-height, which they unfortunately called Fira Code as well. As far as I know, nobody is very attached to that version of Fira Mono, either as a name or as a font.

I hope my arguments convince you that Fira Code name is de facto associated with ligatures font, which I ask you to add in this issue. Please reconsider. And thank you for what you’re doing!

Best,
Nikita

@eriawan
Copy link

eriawan commented Feb 26, 2018

@davelab6
I support @tonsky comment above. Fira Mono is simply a fork of Fira Code, and both of them are different.

Fira Code (original, my repo) is a significantly different version that adds more than 100+ ligatures to Fira Mono, designed to improve how programs (code) looks on screen

Yes, his comment above is also true.
Please reconsider to add the original Fira Code to Google Fonts.

@AronT-TLV
Copy link

👆👆🏻👆🏼👆🏽👆🏾👆🏿

Fira Code is THE best font for code editing. Fira Mono doesn’t come close. Please reconsider

@ai
Copy link

ai commented Feb 26, 2018

Ligatures of Fira Code is very useful

@pozda
Copy link

pozda commented Feb 26, 2018

@tonsky made usable font for developers, i have been using it for year and half. it would be great for us developers to have it as google font so we can use it on posts and pages in code blocks.

i'm supporting @tonsky 100% on this.

also fira mono? why should i as developer use that instead of tonsky's font?

@YBogomolov
Copy link

Fira Code's ligatures is one of the best things that happened to my Haskell and JS development experience. I strongly support @tonsky on this.

@davelab6 davelab6 reopened this Feb 26, 2018
@davelab6
Copy link
Member

Thanks for all the context, everyone :)

If there's real utility in this, I'm happy to add it - but, I would rather see this contributed upstream into Fira Mono proper.

I heard that @carrois is working on a new version of the Fira font (https://github.com/bBoxType/FiraGO) but that currently has Mono/Code version as a future plan on the roadmap.

@tonsky would you be willing to contribute your work upstream? :)

@tonsky
Copy link
Author

tonsky commented Feb 26, 2018

I discussed that when I just started Fira Code, they didn’t want contributions back then (4 years ago), but had plans to reimplement that themselves. As you can see, they are still plans, Mono hasn’t changed much since then. I think they have different focus (Sans, not Mono) and lack of funding (it’s open font after all) which makes all changes in Fira really, really slow

@eriawan
Copy link

eriawan commented Feb 27, 2018

@davelab6

I heard that @carrois is working on a new version of the Fira font (https://github.com/bBoxType/FiraGO) but that currently has Mono/Code version as a future plan on the roadmap.

Why do you insist on using Fira Mono? Knowing the fact that Fira Code is far more active and better font than Fira Mono, also I couldn't even see a concrete roadmap on Fira Mono. Please elaborate.
Also imho @tonsky is correct about the prolonged inactive of Fira Mono.

@resoursa
Copy link

  • from me

@MHLut
Copy link

MHLut commented Feb 27, 2018

Bump! I love this font. It's easy to read and has been my go-to programming font for years, also, the included ligatures are a plus.

@blackxored
Copy link

I second this.

@davelab6
Copy link
Member

davelab6 commented Mar 3, 2018

@eriawan the product values include simplicity, and having lots of versions of the same typeface is confusing. When I first looked at this, I said line-space can be controlled on the web via CSS so there was no need for this. Now I am ok to add it because there is a value.

@eriawan
Copy link

eriawan commented Mar 18, 2018

@davelab6
Great! Thanks for this wonderful decision updates!

@davelab6
Copy link
Member

Why do you insist on using Fira Mono?

We have permission from Mozilla to use Fira Mono, but not Fira Code. Maybe Mozilla can drop the RFN :)

Also, I believe FiraGO has been funded, per the legal details in that README :)

@stamminator
Copy link

I discussed that when I just started Fira Code, they didn’t want contributions back then (4 years ago), but had plans to reimplement that themselves. As you can see, they are still plans, Mono hasn’t changed much since then. I think they have different focus (Sans, not Mono) and lack of funding (it’s open font after all) which makes all changes in Fira really, really slow
- @tonsky

For this reason, I think it's reasonable for Google to reconsider adding this as its own font. Who wants to wait around forever for this?

@tonsky
Copy link
Author

tonsky commented Mar 26, 2018

I’m currently awaiting reply from Mozilla, but they don’t seem to be very responsive. Contact email is dead too :(

@rob10e
Copy link

rob10e commented Jun 27, 2018

Fira Code for the win!
Please add Fira Code, I use it in all of my development environments.

@davelab6
Copy link
Member

davelab6 commented Jun 27, 2018 via email

@johnmichel
Copy link

@davelab6 Given the RFN removal, is there any new traction on getting this added?

@JavierSegoviaCordoba
Copy link

JavierSegoviaCordoba commented Aug 23, 2018

Fira Code >= Fira Mono

Woops... so ugly this >= because GitHub doesn't has ligatures like Fira Mono

@stamminator
Copy link

@JavierSegoviaCordoba I use https://userstyles.org/styles/37035/github-dark for dark mode on GitHub, and it also makes choosing the font easy. Just enter whatever version of Fira Code you have installed on your OS into the "Code Font" field under "Customize Settings" (in my case, it's "Fira Code Regular"), and you're good to go.

image

@Ir1d
Copy link

Ir1d commented Oct 2, 2018

Hi, I wonder if there's a plan on adding Fira Code to Google Fonts. Thx!

@RobertWHurst
Copy link

Any chance this will be added in the next few weeks? I'd like to use FiraCode for my Monaco editor instances, and ideally source my fonts from Google fonts.

@cfanoulis
Copy link

bump. anything on this?

@rnetonet
Copy link

Anyway we can help with this ? Testing or something ?

@davelab6
Copy link
Member

davelab6 commented Dec 12, 2018 via email

@davelab6 davelab6 added VF New and removed VF New labels Jan 11, 2019
@thundernixon thundernixon self-assigned this Jan 30, 2019
@thundernixon
Copy link
Collaborator

@davelab6 Wait, is the RFN really removed?

https://github.com/mozilla/Fira/blob/master/LICENSE#L1 currently includes:

Digitized data copyright (c) 2012-2015, The Mozilla Foundation and Telefonica S.A.
with Reserved Font Name < Fira >,

@davelab6
Copy link
Member

davelab6 commented Feb 9, 2019

Yes, but the pr (mozilla/Fira#219) wasn't merged, but the rfn was cleared to be removed.

@thundernixon
Copy link
Collaborator

Awesome, thanks for letting me know!

@thundernixon
Copy link
Collaborator

Fira Code is QAed and ready to merge, but is currently blocked by mozilla/Fira#219.

If folks come across this who would like to see Fira Code on Google Fonts, go upvote that PR.

@cfanoulis
Copy link

The PR above has been merged recently 🎉

cc: @thundernixon @davelab6

@thundernixon thundernixon changed the title Add Fira Code - blocked by mozilla/Fira#219 Add Fira Code - on deck to merge! May 11, 2019
@dhouck
Copy link

dhouck commented Jun 8, 2019

How long do things typically remain on deck to merge before they actually get merged?

@lukepighetti
Copy link

Its like I can hear the machinery turning in the distance.

@lifepeer
Copy link

The fact that this no-brainer has so far taken 1 year 4 months 18 days and 23 hours, and still isn't done, is quite depressing. :(

@cfanoulis
Copy link

cfanoulis commented Jul 16, 2019

Uhh, why was this closed? It surely isnt because it was added, since https://fonts.google.com/?query=Fira+Code return no results :(

EDIT: I seem to miss the ability to read. It just seems as if the cache hasnt been updated

@m4rc1e m4rc1e reopened this Jul 16, 2019
@dhouck
Copy link

dhouck commented Jul 16, 2019

Usually GitHub bugs are closed when the repository has the issue fixed, not when the fix is actually deployed.

@cfanoulis
Copy link

yes, I didn't realize that the thing had been added

Pardon my stupidity

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 29, 2019

Now online https://fonts.google.com/specimen/Fira+Code.

thank you @tonsky and @thundernixon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.