Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Example Documentation #2782

Closed
marcvanzee opened this issue Jan 9, 2023 Discussed in #2779 · 4 comments · Fixed by #3453
Closed

Feature Request: Example Documentation #2782

marcvanzee opened this issue Jan 9, 2023 Discussed in #2779 · 4 comments · Fixed by #3453
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.

Comments

@marcvanzee
Copy link
Collaborator

Discussed in #2779

Originally posted by shenoynikhil January 8, 2023
In the API Reference, is it possible to have an example for each module. It's generally easy to understand the usage from an example.

The request is inspired from pytorch (example shared below for torch.nn.Conv2D Link)
Screenshot 2023-01-08 at 2 29 15 PM

I am also willing to help out to improve the documentation if I can get some support :).

@IvyZX
Copy link
Collaborator

IvyZX commented Jan 10, 2023

Most of the modules actually are used in flax/examples or in some documentation tutorials.
For example, from what I've seen for now, Dense and Conv are used in Getting Started, and BatchNorm and Dropout have their own guides.

It might be a good practice to at least put a link on the docstring so that users can see it from API Reference.

@shenoynikhil
Copy link

I'll be glad to help improve the documentation.

@IvyZX
Copy link
Collaborator

IvyZX commented Jan 11, 2023

Thank you @shenoynikhil for offering help! When you have a PR please let us know.

@cgarciae cgarciae added the Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. label Jan 25, 2023
@cgarciae
Copy link
Collaborator

There are efforts on this direction (e.g. #2792) however it will take time to improve all docstrings so I set the tag for this issue to eventual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants