Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emboss fails to run on Python 3.9 #167

Open
jasongraffius opened this issue Aug 7, 2024 · 2 comments
Open

Emboss fails to run on Python 3.9 #167

jasongraffius opened this issue Aug 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jasongraffius
Copy link
Collaborator

In addition to #136 , Emboss fails to run on Python 3.9, which unlike 3.8 is not near the end of the support horizon. The failures appear to be related to typechecking:

/home/jason/.cache/bazel/_bazel_jason/3f005b1d454ca9fd185dd4ffbad81e8e/sandbox/linux-sandbox/1366/execroot/com_google_emboss/bazel-out/k8-fastbuild/bin/compiler/back_end/cpp/header_generator_test.runfiles/com_google_emboss/compiler/util/ir_data_fields.py", line 290, in <module>
    def field_specs(obj: IrDataT | type[IrDataT]) -> Mapping[str, FieldSpec]:
TypeError: unsupported operand type(s) for |: 'TypeVar' and 'types.GenericAlias'
@jasongraffius
Copy link
Collaborator Author

I should mention I have confirmed that python 3.10+ does work, it is only 3.8 and 3.9 of the supported versions that are failing.

@EricRahm
Copy link
Collaborator

EricRahm commented Aug 8, 2024

Yeah that's probably my recent changes. Having a check in CI will definitely help prevent this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants