Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the inlined header.article-meta with call to a partial, and fix rendering when empty #2156

Open
chalin opened this issue Jan 7, 2025 · 0 comments
Labels
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jan 7, 2025

The element <header class="article-meta"> is inlined in several layouts, with the same content I believe (and will double check):

layouts/_default/content.html:
  4: 	<header class="article-meta">
  5  		{{ partial "taxonomy_terms_article_wrapper.html" . -}}

layouts/_default/taxonomy.html:
  20:           <header class="article-meta">
  21              {{ partial "taxonomy_terms_article_wrapper.html" . -}}

layouts/blog/content.html:
  8: 	<header class="article-meta">
  9  		{{ partial "taxonomy_terms_article_wrapper.html" . -}}

layouts/blog/list.html:
  22:         <header class="article-meta">
  23            {{- partial "taxonomy_terms_article_wrapper.html" . -}}

layouts/docs/list.html:
  5: 	<header class="article-meta">
  6  		{{ partial "taxonomy_terms_article_wrapper.html" . -}}

layouts/swagger/list.html:
  5: 	<header class="article-meta">
  6  		{{ partial "taxonomy_terms_article_wrapper.html" . -}}

IMHO, there are formatting issues the result from that header element being included in pages while still being empty. It would be best to fix this after refactoring the layouts to use a single partial.

@chalin chalin added cleanup/refactoring design/style Front-end site design / styling e0-minutes Effort < 60 min e1-hours p2-medium labels Jan 7, 2025
@chalin chalin added this to the 25Q1 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant