MOE Sync 2019-12-16 #1696
Merged
MOE Sync 2019-12-16 #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*** Reason for rollback *** To rollback *** Original change description *** Throw if metadata is missing when calling getSynthethicPropertyAnnotations. *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284668065
*** Reason for rollback *** Caused b/145946461 *** Original change description *** Propagate qualifiers for field injections in MemberInjectors. Having qualifiers in the generated MemberInjectors helps the root downstream processor read Kotlin property annotations that are lost across compilations due to https://youtrack.jetbrains.com/issue/KT-34684 When Dagger is applied to all subprojects with @Inject fields or constructors then this change fixes #1659. *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284670569
…jectors. NEW: Added logic InjectionAnnotations to deduplicate qualifiers annotation in the case that a qualifier is present in the field but a missing property annotation is also detected and the annotations from the members injector are also gathered. Automated g4 rollback of changelist 284670569. *** Reason for rollback *** Rolling forward *** Original change description *** Automated g4 rollback of changelist 283574407. *** Reason for rollback *** Caused b/145946461 *** Original change description *** Propagate qualifiers for field injections in MemberInjectors. Having qualifiers in the generated MemberInjectors helps the root downstream processor read Kotlin property annotations that are lost across compilations due to https://youtrack.jetbrains.com/issue/KT-34684 When Dagger is applied to all subprojects with @Inject fields or constructors then this change f... *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284863380
…icPropertyAnnotations. Automated g4 rollback of changelist 284668065. *** Reason for rollback *** Rolling forward *** Original change description *** Automated g4 rollback of changelist 284558322. *** Reason for rollback *** To rollback *** Original change description *** Throw if metadata is missing when calling getSynthethicPropertyAnnotations. *** *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=285425340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Automated g4 rollback of changelist 284558322.
*** Reason for rollback ***
To rollback
*** Original change description ***
Throw if metadata is missing when calling getSynthethicPropertyAnnotations.
824d725
Automated g4 rollback of changelist 283574407.
*** Reason for rollback ***
Caused b/145946461
*** Original change description ***
Propagate qualifiers for field injections in MemberInjectors.
Having qualifiers in the generated MemberInjectors helps the root
downstream processor read Kotlin property annotations that are lost
across compilations due to https://youtrack.jetbrains.com/issue/KT-34684
When Dagger is applied to all subprojects with @Inject fields or
constructors then this change fixes #1659.
8bfbc59
Roll forward of Propagate qualifiers for field injections in MemberInjectors.
NEW: Added logic InjectionAnnotations to deduplicate qualifiers annotation in the case that a qualifier is present in the field but a missing property annotation is also detected and the annotations from the members injector are also gathered.
Automated g4 rollback of changelist 284670569.
*** Reason for rollback ***
Rolling forward
*** Original change description ***
Automated g4 rollback of changelist 283574407.
*** Reason for rollback ***
Caused b/145946461
*** Original change description ***
Propagate qualifiers for field injections in MemberInjectors.
Having qualifiers in the generated MemberInjectors helps the root
downstream processor read Kotlin property annotations that are lost
across compilations due to https://youtrack.jetbrains.com/issue/KT-34684
When Dagger is applied to all subprojects with @Inject fields or
constructors then this change f...
3367d68
Roll forward of Throw if metadata is missing when calling getSynthethicPropertyAnnotations.
Automated g4 rollback of changelist 284668065.
*** Reason for rollback ***
Rolling forward
*** Original change description ***
Automated g4 rollback of changelist 284558322.
*** Reason for rollback ***
To rollback
*** Original change description ***
Throw if metadata is missing when calling getSynthethicPropertyAnnotations.
87a5b33