Enum values in Qualifiers not referenced correctly anymore

[bentatham]

Version: 2.44

When a Qualifier on an @Inject member field has an enum value, like this:

  @Inject
  @StartTime(StartTime.Units.MILLIS)
  long startTimeMillis;

the generated MembersInjector no longer references the enum value correctly (it drops the referencing classes and/or necessary imports):

  @InjectedFieldSignature("ca.nanometrics.apollo.core.MissionControlApollo.startTimeMillis")
  @ApolloCoreModule.StartTime(MILLIS)
  public static void injectStartTimeMillis(MissionControlApollo instance,
      long startTimeMillis) {
    instance.startTimeMillis = startTimeMillis;
  }

and therefore causes a compile failure:

diagnostic: /home/bentatham/git/products_apollo-server/apollo-core/target/generated-sources/annotations/ca/nanometrics/apollo/core/MissionControlApollo_MembersInjector.java:72: error: cannot find symbol
  @ApolloCoreModule.StartTime(MILLIS)
                              ^
  symbol:   variable MILLIS
  location: class ca.nanometrics.apollo.core.MissionControlApollo_MembersInjector

In previous versions, up to 2.43.2, it worked fine and generated this code:

  @InjectedFieldSignature("ca.nanometrics.apollo.core.MissionControlApollo.startTimeMillis")
  @ApolloCoreModule.StartTime(ApolloCoreModule.StartTime.Units.MILLIS)
  public static void injectStartTimeMillis(MissionControlApollo instance,
      long startTimeMillis) {
    instance.startTimeMillis = startTimeMillis;
  }

[bcorso]

Hi @bentatham, thanks for reporting this!

Looks like this was a bug in our XProcessing dependency that was fixed upstream in aosp/2170603 but unfortunately didn't make it into the 2.44 release in time. However, it should be fixed at HEAD, so I'm going to go ahead and close this.

I can look into doing another Dagger release this week that should include this fix.